github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 03:09:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #880] [MERGED] Support for establishing a username field without a password field #2637

New Issue
Closed
opened 2025-11-26 23:22:01 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:01 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/880
Author: @mpbw2
Created: 5/5/2020
Status: ✅ Merged
Merged: 5/6/2020
Merged by: @mpbw2

Base: master ← Head: feature-acc-usernamefield

📝 Commits (2)

  • 94ed202 Support for establishing a username field without a password field
  • 5eb9eab added aws login

📊 Changes

4 files changed (+87 additions, -23 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+56 -10)
📝 src/Android/Accessibility/AccessibilityService.cs (+14 -13)
➕ src/Android/Accessibility/KnownUsernameField.cs (+16 -0)
📝 src/Android/Android.csproj (+1 -0)

📄 Description

Accessibility: Added support for establishing a username field without the presence of a password field, or for overriding a username field with a different one (think github homepage user/email/pass form). As there doesn't appear to be a reliable way to make this work automagically, this takes the manual route where we simply maintain a list of sites and their corresponding username field IDs.

I opted not to use the entire URI as some of the variations were endless depending on locale, continuation path args, etc. So we're keying off the authority and the end of the path to establish a site & page match, then on the view ID for a username field match.

Additional data was needed earlier in the process to establish the username field, so some operations were shuffled around to prevent them from running twice.

device-2020-05-05-175044

device-2020-05-05-181429

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/880 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 5/5/2020 **Status:** ✅ Merged **Merged:** 5/6/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `feature-acc-usernamefield` --- ### 📝 Commits (2) - [`94ed202`](https://github.com/bitwarden/android/commit/94ed2027ba25da83c07a83b38122a3501680cc1c) Support for establishing a username field without a password field - [`5eb9eab`](https://github.com/bitwarden/android/commit/5eb9eab2ae2d29bf88766c34c6ec5c4047c26e00) added aws login ### 📊 Changes **4 files changed** (+87 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+56 -10) 📝 `src/Android/Accessibility/AccessibilityService.cs` (+14 -13) ➕ `src/Android/Accessibility/KnownUsernameField.cs` (+16 -0) 📝 `src/Android/Android.csproj` (+1 -0) </details> ### 📄 Description Accessibility: Added support for establishing a username field without the presence of a password field, or for overriding a username field with a different one (think github homepage user/email/pass form). As there doesn't appear to be a reliable way to make this work automagically, this takes the manual route where we simply maintain a list of sites and their corresponding username field IDs. I opted not to use the entire URI as some of the variations were endless depending on locale, continuation path args, etc. So we're keying off the authority and the end of the path to establish a site & page match, then on the view ID for a username field match. Additional data was needed earlier in the process to establish the username field, so some operations were shuffled around to prevent them from running twice. ![device-2020-05-05-175044](https://user-images.githubusercontent.com/59324545/81120654-2bbd8e80-8efb-11ea-9691-f3d7336feb37.png) ![device-2020-05-05-181429](https://user-images.githubusercontent.com/59324545/81121276-565c1700-8efc-11ea-8f11-d2614f39c583.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2637
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?