github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 22:25:22 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #869] [MERGED] Add support for Brave Nightly (also: variants "_dev" and "_default") #2629

New Issue
Closed
opened 2025-11-26 23:21:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/869
Author: @contribucious
Created: 5/2/2020
Status: ✅ Merged
Merged: 5/4/2020
Merged by: @mpbw2

Base: master ← Head: brave-variants-support

📝 Commits (3)

  • 4861712 [Brave] Add all other variants to AccessibilityHelpers.SupportedBrowsers
  • 6b5b87f [Brave] Add all other variants to AutofillHelpers.CompatBrowsers
  • c699211 [Brave] Add all other variants to autofillservice.xml

📊 Changes

3 files changed (+15 additions, -0 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+3 -0)
📝 src/Android/Autofill/AutofillHelpers.cs (+3 -0)
📝 src/Android/Resources/xml/autofillservice.xml (+9 -0)

📄 Description

Brave_logo

This:

  • adds support for Brave Nightly (com.brave.browser_nightly) and
  • adds the Brave variants com.brave.browser_dev and com.brave.browser_default.

Based on official information found here (link using the last tree at the time of writing).

Read more ...

Screenshot (for resource-id value)

Brave_Nightly_resource-id
➡️ com.brave.browser_nightly:id/ url_bar

See also ...

Global context

The new release is based on the same Chromium code repository as our Brave desktop release, and will allow for easier implementations of features and fixes across desktop and mobile thanks to a unified codebase. For example, this unified codebase will enable support for extensions in Android in the future.

Source: https://brave.com/rebuilt-brave-android/ (Apr 6, 2020)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/869 **Author:** [@contribucious](https://github.com/contribucious) **Created:** 5/2/2020 **Status:** ✅ Merged **Merged:** 5/4/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `brave-variants-support` --- ### 📝 Commits (3) - [`4861712`](https://github.com/bitwarden/android/commit/48617120c4279b923b356d8b5ad9e30d72cc029e) [Brave] Add all other variants to AccessibilityHelpers.SupportedBrowsers - [`6b5b87f`](https://github.com/bitwarden/android/commit/6b5b87f6d418fc245644d1efe5cd1524f1de95eb) [Brave] Add all other variants to AutofillHelpers.CompatBrowsers - [`c699211`](https://github.com/bitwarden/android/commit/c699211d82cd2bdd7e8628c0be0beb688a8265bd) [Brave] Add all other variants to autofillservice.xml ### 📊 Changes **3 files changed** (+15 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+3 -0) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+3 -0) 📝 `src/Android/Resources/xml/autofillservice.xml` (+9 -0) </details> ### 📄 Description ___ ![Brave_logo](https://user-images.githubusercontent.com/4764956/80848184-b0b25a80-8c12-11ea-835e-b128a7530af0.png) ___ This: - adds support for **Brave Nightly** (`com.brave.browser_nightly`) and - adds the Brave variants `com.brave.browser_dev` and `com.brave.browser_default`. Based on official information found [here](https://github.com/brave/brave-browser/blob/1bd60da7aad1edbb2f8f1cc64e3076e9fddf6081/lib/config.js#L225-L241) _(link using the last tree at the time of writing)_. <details> <summary>Read more ...</summary> ### Screenshot (for _resource-id_ value) ![Brave_Nightly_resource-id](https://user-images.githubusercontent.com/4764956/80907101-028ed980-8d14-11ea-816f-8ee9087eefbc.png) :arrow_right: `com.brave.browser_nightly:id/` **`url_bar`** ### See also ... - [Official explanation of the different versions](https://www.reddit.com/r/brave_browser/comments/cwxtpl/what_is_the_best_version_of_brave_browser/eyjjkic/). - [Nightly version in action](https://github.com/brave/brave-browser/issues/8737) (APKs available on [their GitHub](https://github.com/brave/brave-browser/releases)). ### Global context > The new release is based on the same Chromium code repository as our Brave desktop release, and will allow for easier implementations of features and fixes across desktop and mobile thanks to a unified codebase. For example, this unified codebase will enable support for extensions in Android in the future. > > **Source:** https://brave.com/rebuilt-brave-android/ (Apr 6, 2020) </details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2629
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?