github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6776] [MERGED] [PM-34833] bug: Search improvements #26237

New Issue
Closed
opened 2026-04-17 01:43:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 01:43:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6776
Author: @gabrbrand
Created: 4/9/2026
Status: ✅ Merged
Merged: 4/10/2026
Merged by: @david-livefront

Base: main ← Head: search-improvements

📝 Commits (6)

  • 3aa157c Show search icon only when content is displayed
  • 677fd99 Hide clear icon when search term is empty
  • f3ea7f9 Use formatted search string
  • 42cc6da Adjust tests
  • bd377f8 Add isDisplayed parameter to BitwardenSearchActionItem
  • 52b3a4c Rename formatted search string to search_x

📊 Changes

15 files changed (+105 additions, -44 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt (+10 -30)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendScreen.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModel.kt (+5 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+6 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+6 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendScreenTest.kt (+9 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt (+9 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt (+26 -2)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt (+5 -6)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingViewModel.kt (+6 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/appbar/BitwardenSearchTopAppBar.kt (+16 -5)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/appbar/action/BitwardenSearchActionItem.kt (+3 -0)
📝 ui/src/main/res/values/strings.xml (+1 -1)

📄 Description

📔 Objective

Improvements to the search experience:

  • Show search icon only when content is displayed. Hidden when content is loading, there is an error or there are no items.
  • Hide clear icon when search term is empty. (Animated)
  • Use a formatted search string instead of hard coding the order. e.g. in German the words are in a different order

📸 Screenshots

https://github.com/user-attachments/assets/adffdbf1-e950-41e6-a135-8b53b8a88305

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6776 **Author:** [@gabrbrand](https://github.com/gabrbrand) **Created:** 4/9/2026 **Status:** ✅ Merged **Merged:** 4/10/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `search-improvements` --- ### 📝 Commits (6) - [`3aa157c`](https://github.com/bitwarden/android/commit/3aa157c22bdeb49c41d6f5aef4631bc7ef1d5d12) Show search icon only when content is displayed - [`677fd99`](https://github.com/bitwarden/android/commit/677fd9912d2c030dab5a615f1d57ae8d0cfaef75) Hide clear icon when search term is empty - [`f3ea7f9`](https://github.com/bitwarden/android/commit/f3ea7f971d2ad6ba57035fc04b229f7450ed9304) Use formatted search string - [`42cc6da`](https://github.com/bitwarden/android/commit/42cc6da3eb0072be374210a1a02ecd7778505e00) Adjust tests - [`bd377f8`](https://github.com/bitwarden/android/commit/bd377f8862c1cdfca8bf33e350eb079a48d7508c) Add isDisplayed parameter to BitwardenSearchActionItem - [`52b3a4c`](https://github.com/bitwarden/android/commit/52b3a4ccc186d8e2329904376e1714856941d7fc) Rename formatted search string to search_x ### 📊 Changes **15 files changed** (+105 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt` (+10 -30) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendScreen.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModel.kt` (+5 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+6 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+6 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/SendScreenTest.kt` (+9 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt` (+9 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt` (+26 -2) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt` (+5 -6) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingViewModel.kt` (+6 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/appbar/BitwardenSearchTopAppBar.kt` (+16 -5) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/appbar/action/BitwardenSearchActionItem.kt` (+3 -0) 📝 `ui/src/main/res/values/strings.xml` (+1 -1) </details> ### 📄 Description ## 📔 Objective Improvements to the search experience: - Show search icon only when content is displayed. Hidden when content is loading, there is an error or there are no items. - Hide clear icon when search term is empty. (Animated) - Use a formatted search string instead of hard coding the order. e.g. in German the words are in a different order ## 📸 Screenshots https://github.com/user-attachments/assets/adffdbf1-e950-41e6-a135-8b53b8a88305 <img width="250" src="https://github.com/user-attachments/assets/a026bd13-1c15-4946-8f5a-c23e18d0aef9" /> <img width="250" src="https://github.com/user-attachments/assets/bc42e83d-baac-47bd-b3f4-c10fae0b2777" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 01:43:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#26237
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?