github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6774] [MERGED] PM-33458: feat: Add speed bump when archiving item from a list #26236

New Issue
Closed
opened 2026-04-17 01:43:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 01:43:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6774
Author: @david-livefront
Created: 4/8/2026
Status: ✅ Merged
Merged: 4/10/2026
Merged by: @david-livefront

Base: main ← Head: PM-33458-archive-speed-bump

📝 Commits (1)

  • 540a412 PM-33458: Add speed bump when archiving item from a list

📊 Changes

10 files changed (+341 additions, -104 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchContent.kt (+29 -40)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingContent.kt (+30 -40)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/model/ListingItemOverflowAction.kt (+38 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt (+33 -3)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreenTest.kt (+46 -21)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt (+49 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt (+51 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/dialog/BitwardenTwoButtonDialog.kt (+44 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/components/dialog/model/BitwardenTwoButtonDialogData.kt (+19 -0)
📝 ui/src/main/res/values/strings_non_localized.xml (+2 -0)

📄 Description

🎟️ Tracking

PM-33458

📔 Objective

This PR adds a speed bump dialog when archiving an item from any of the listing screens.

  • Main Vault Screen
  • Individual list screens.
  • Search Screen

📸 Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6774 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 4/8/2026 **Status:** ✅ Merged **Merged:** 4/10/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-33458-archive-speed-bump` --- ### 📝 Commits (1) - [`540a412`](https://github.com/bitwarden/android/commit/540a412bd1395794f2dc294b4d8fdddfbd15dc6d) PM-33458: Add speed bump when archiving item from a list ### 📊 Changes **10 files changed** (+341 additions, -104 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchContent.kt` (+29 -40) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingContent.kt` (+30 -40) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/model/ListingItemOverflowAction.kt` (+38 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt` (+33 -3) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreenTest.kt` (+46 -21) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt` (+49 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt` (+51 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/dialog/BitwardenTwoButtonDialog.kt` (+44 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/components/dialog/model/BitwardenTwoButtonDialogData.kt` (+19 -0) 📝 `ui/src/main/res/values/strings_non_localized.xml` (+2 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-33458](https://bitwarden.atlassian.net/browse/PM-33458) ## 📔 Objective This PR adds a speed bump dialog when archiving an item from any of the listing screens. * Main Vault Screen * Individual list screens. * Search Screen ## 📸 Screenshots <img width="350" src="https://github.com/user-attachments/assets/021d7669-b231-4ef2-a0c7-2c91baf2a60b" /> [PM-33458]: https://bitwarden.atlassian.net/browse/PM-33458?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 01:43:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#26236
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?