github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 17:16:20 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #6726] [MERGED] llm: Add test constants placement rule to testing skill #26201

New Issue
Closed
opened 2026-04-17 01:42:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 01:42:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6726
Author: @SaintPatrck
Created: 3/27/2026
Status: ✅ Merged
Merged: 3/30/2026
Merged by: @SaintPatrck

Base: main ← Head: llm/build-test-verify_test-const-placement-rule

📝 Commits (1)

  • 5558e8b llm: Add test constants placement rule to testing skill

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 .claude/skills/testing-android-code/SKILL.md (+4 -0)

📄 Description

🎟️ Tracking

LLM tooling improvement — no Jira ticket.

📔 Objective

Add a "Test Constants Placement" section to the testing-android-code skill documenting the convention: declare test constants as top-level private const val at the bottom of the file, not inside companion object.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6726 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/27/2026 **Status:** ✅ Merged **Merged:** 3/30/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `llm/build-test-verify_test-const-placement-rule` --- ### 📝 Commits (1) - [`5558e8b`](https://github.com/bitwarden/android/commit/5558e8ba63a85f18079016d58a20b6cb054106a7) llm: Add test constants placement rule to testing skill ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.claude/skills/testing-android-code/SKILL.md` (+4 -0) </details> ### 📄 Description ## 🎟️ Tracking LLM tooling improvement — no Jira ticket. ## 📔 Objective Add a "Test Constants Placement" section to the `testing-android-code` skill documenting the convention: declare test constants as top-level `private const val` at the bottom of the file, not inside `companion object`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 01:42:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#26201
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?