github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6720] [MERGED] [PM-34125] feat: Add card text analysis pipeline #26195

New Issue
Closed
opened 2026-04-17 01:42:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 01:42:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6720
Author: @SaintPatrck
Created: 3/26/2026
Status: ✅ Merged
Merged: 4/6/2026
Merged by: @SaintPatrck

Base: main ← Head: card-scanner/2-text-analysis-pipeline

📝 Commits (6)

  • ef3f7d2 [PM-34125] feat: Add card text analysis pipeline
  • 0ee86f3 Address code review feedback
  • 8419f36 Address code review feedback for card scanner
  • 989474c Return null from parseCardData when no card data is detected
  • 65e6bd2 Remove Closeable implementation from CardTextAnalyzerImpl
  • 8299421 Remove cardholder name from card scan data and parsing

📊 Changes

16 files changed (+794 additions, -0 deletions)

View changed files

➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/util/CardNumberUtils.kt (+95 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/util/CardNumberUtilsTest.kt (+107 -0)
📝 gradle/libs.versions.toml (+2 -0)
📝 ui/build.gradle.kts (+1 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/components/camera/CardScanOverlay.kt (+73 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/composition/LocalProviders.kt (+9 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardDataParser.kt (+14 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardDataParserImpl.kt (+66 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardNumberUtils.kt (+33 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardScanData.kt (+21 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardTextAnalyzer.kt (+16 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardTextAnalyzerImpl.kt (+63 -0)
📝 ui/src/main/res/values/strings.xml (+2 -0)
➕ ui/src/test/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardDataParserImplTest.kt (+225 -0)
➕ ui/src/test/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardNumberUtilsTest.kt (+47 -0)
➕ ui/src/testFixtures/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/FakeCardTextAnalyzer.kt (+20 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34125

📔 Objective

Add the complete text analysis pipeline for credit card scanning:

  • CardNumberUtils: Shared Luhn validation and card number sanitization (ui module)
  • CardDataParser: Interface and regex-based implementation for extracting card details from OCR text (number, expiry, CVV)
  • CardTextAnalyzer: ML Kit Text Recognition integration for camera frame analysis
  • CardScanOverlay: Camera overlay composable for scan UI
  • CardScanData: Data class for parsed card fields
  • CardNumberUtils in app: Brand detection (detectCardBrand) using VaultCardBrand

Includes full test coverage for parser logic, Luhn validation, and sanitization.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6720 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/26/2026 **Status:** ✅ Merged **Merged:** 4/6/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `card-scanner/2-text-analysis-pipeline` --- ### 📝 Commits (6) - [`ef3f7d2`](https://github.com/bitwarden/android/commit/ef3f7d21647d34333927e4f179448ac6fd133ee1) [PM-34125] feat: Add card text analysis pipeline - [`0ee86f3`](https://github.com/bitwarden/android/commit/0ee86f3095f7b18eb2d93660c1d0578cd323fc45) Address code review feedback - [`8419f36`](https://github.com/bitwarden/android/commit/8419f36ab1bd772bf631b01fb8e3a9480552a567) Address code review feedback for card scanner - [`989474c`](https://github.com/bitwarden/android/commit/989474c14ea3a75a480257b048a02287f23d567c) Return null from parseCardData when no card data is detected - [`65e6bd2`](https://github.com/bitwarden/android/commit/65e6bd212fca2f3189f966909d8dbb258291b290) Remove Closeable implementation from CardTextAnalyzerImpl - [`8299421`](https://github.com/bitwarden/android/commit/82994216ee539c63dce4fbebd73e79ef9b1258e6) Remove cardholder name from card scan data and parsing ### 📊 Changes **16 files changed** (+794 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/util/CardNumberUtils.kt` (+95 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/util/CardNumberUtilsTest.kt` (+107 -0) 📝 `gradle/libs.versions.toml` (+2 -0) 📝 `ui/build.gradle.kts` (+1 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/components/camera/CardScanOverlay.kt` (+73 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/composition/LocalProviders.kt` (+9 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardDataParser.kt` (+14 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardDataParserImpl.kt` (+66 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardNumberUtils.kt` (+33 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardScanData.kt` (+21 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardTextAnalyzer.kt` (+16 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardTextAnalyzerImpl.kt` (+63 -0) 📝 `ui/src/main/res/values/strings.xml` (+2 -0) ➕ `ui/src/test/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardDataParserImplTest.kt` (+225 -0) ➕ `ui/src/test/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/CardNumberUtilsTest.kt` (+47 -0) ➕ `ui/src/testFixtures/kotlin/com/bitwarden/ui/platform/feature/cardscanner/util/FakeCardTextAnalyzer.kt` (+20 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-34125 ## 📔 Objective Add the complete text analysis pipeline for credit card scanning: - **CardNumberUtils**: Shared Luhn validation and card number sanitization (ui module) - **CardDataParser**: Interface and regex-based implementation for extracting card details from OCR text (number, expiry, CVV) - **CardTextAnalyzer**: ML Kit Text Recognition integration for camera frame analysis - **CardScanOverlay**: Camera overlay composable for scan UI - **CardScanData**: Data class for parsed card fields - **CardNumberUtils in app**: Brand detection (`detectCardBrand`) using `VaultCardBrand` Includes full test coverage for parser logic, Luhn validation, and sanitization. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 01:42:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#26195
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?