github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-16 17:14:25 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #847] [MERGED] Allow a BiometricPrompt to succeed after an initial failure #2613

New Issue
Closed
opened 2025-11-26 23:21:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/847
Author: @watk
Created: 4/22/2020
Status: ✅ Merged
Merged: 4/23/2020
Merged by: @mpbw2

Base: master ← Head: fix-biometrics-prompt-bug

📝 Commits (1)

  • c1a3028 Allow a BiometricPrompt to succeed after an initial failure (#791)

📊 Changes

1 file changed (+9 additions, -1 deletions)

View changed files

📝 src/Android/Services/DeviceActionService.cs (+9 -1)

📄 Description

Previously a call to BiometricPrompt.AuthenticationCallback#OnAuthenticationFailed()
was treated as though an unrecoverable failure had occurred. However this is called on
each failed fingerprint match, for example, and is not a terminal failure. Now these
intermittent failures are ignored and a call to #OnAuthenticationError() is recognised
as an unrecoverable failure instead.

Fixes #791

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/847 **Author:** [@watk](https://github.com/watk) **Created:** 4/22/2020 **Status:** ✅ Merged **Merged:** 4/23/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `fix-biometrics-prompt-bug` --- ### 📝 Commits (1) - [`c1a3028`](https://github.com/bitwarden/android/commit/c1a3028c13ea899120a03e2a30faed1ad14e5d69) Allow a BiometricPrompt to succeed after an initial failure (#791) ### 📊 Changes **1 file changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/DeviceActionService.cs` (+9 -1) </details> ### 📄 Description Previously a call to BiometricPrompt.AuthenticationCallback#OnAuthenticationFailed() was treated as though an unrecoverable failure had occurred. However this is called on each failed fingerprint match, for example, and is not a terminal failure. Now these intermittent failures are ignored and a call to #OnAuthenticationError() is recognised as an unrecoverable failure instead. Fixes #791 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2613
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?