github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6593] [MERGED] Move the AppStateManager to the data module #26081

New Issue
Closed
opened 2026-04-17 01:37:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 01:37:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6593
Author: @david-livefront
Created: 2/26/2026
Status: ✅ Merged
Merged: 3/2/2026
Merged by: @david-livefront

Base: main ← Head: migrate-app-state-manager

📝 Commits (1)

  • c6ed9d3 Move the AppStateManager to the data module

📊 Changes

17 files changed (+112 additions, -57 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/di/ActivityAutofillModule.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerImpl.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/AutofillIntentUtils.kt (+4 -15)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+0 -8)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt (+3 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/di/VaultManagerModule.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerTest.kt (+2 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt (+3 -3)
📝 data/build.gradle.kts (+1 -0)
➕ data/src/main/kotlin/com/bitwarden/data/autofill/util/AutofillIntentUtils.kt (+56 -0)
📝 data/src/main/kotlin/com/bitwarden/data/manager/appstate/AppStateManager.kt (+5 -6)
📝 data/src/main/kotlin/com/bitwarden/data/manager/appstate/AppStateManagerImpl.kt (+5 -5)
📝 data/src/main/kotlin/com/bitwarden/data/manager/appstate/model/AppCreationState.kt (+1 -1)
📝 data/src/main/kotlin/com/bitwarden/data/manager/appstate/model/AppForegroundState.kt (+1 -1)
📝 data/src/main/kotlin/com/bitwarden/data/manager/di/DataManagerModule.kt (+9 -0)
📝 data/src/test/kotlin/com/bitwarden/data/manager/appstate/AppStateManagerTest.kt (+16 -6)
📝 data/src/testFixtures/kotlin/com/bitwarden/data/manager/appstate/FakeAppStateManager.kt (+3 -4)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR migrates the AppStateManager to the data module so it can be reused in the Authenticator app.

Additional changes required for migration:

  • The AppCreationState.Created state requires the isAutofill flag to be set, so some autofill functionality ha been moved to the data module.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6593 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 3/2/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `migrate-app-state-manager` --- ### 📝 Commits (1) - [`c6ed9d3`](https://github.com/bitwarden/android/commit/c6ed9d3db8508178cdb234ff0512bfa5ce7bfee7) Move the AppStateManager to the data module ### 📊 Changes **17 files changed** (+112 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/di/ActivityAutofillModule.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerImpl.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/AutofillIntentUtils.kt` (+4 -15) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+0 -8) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt` (+3 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/di/VaultManagerModule.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerTest.kt` (+2 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt` (+3 -3) 📝 `data/build.gradle.kts` (+1 -0) ➕ `data/src/main/kotlin/com/bitwarden/data/autofill/util/AutofillIntentUtils.kt` (+56 -0) 📝 `data/src/main/kotlin/com/bitwarden/data/manager/appstate/AppStateManager.kt` (+5 -6) 📝 `data/src/main/kotlin/com/bitwarden/data/manager/appstate/AppStateManagerImpl.kt` (+5 -5) 📝 `data/src/main/kotlin/com/bitwarden/data/manager/appstate/model/AppCreationState.kt` (+1 -1) 📝 `data/src/main/kotlin/com/bitwarden/data/manager/appstate/model/AppForegroundState.kt` (+1 -1) 📝 `data/src/main/kotlin/com/bitwarden/data/manager/di/DataManagerModule.kt` (+9 -0) 📝 `data/src/test/kotlin/com/bitwarden/data/manager/appstate/AppStateManagerTest.kt` (+16 -6) 📝 `data/src/testFixtures/kotlin/com/bitwarden/data/manager/appstate/FakeAppStateManager.kt` (+3 -4) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR migrates the `AppStateManager` to the `data` module so it can be reused in the Authenticator app. Additional changes required for migration: * The `AppCreationState.Created` state requires the `isAutofill` flag to be set, so some autofill functionality ha been moved to the `data` module. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 01:37:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#26081
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?