[PR #840] [MERGED] [Auto-Logout] LockOption refactor - application layer (part 1) #2608

Closed
opened 2025-11-26 23:21:39 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/840
Author: @vincentsalucci
Created: 4/17/2020
Status: Merged
Merged: 4/17/2020
Merged by: @vincentsalucci

Base: feature-auto-logoutHead: fal-lock-option-refactor


📝 Commits (1)

  • 98e1a52 Initial commit: lockOption/lock refactor app layer

📊 Changes

3 files changed (+50 additions, -41 deletions)

View changed files

📝 src/Android/MainActivity.cs (+9 -9)
📝 src/App/App.xaml.cs (+22 -13)
📝 src/iOS/AppDelegate.cs (+19 -19)

📄 Description

Objective

Change existing lockOption variables, method names, and message commands to use the ...vaultTimeout... pattern.

Code Changes

  • MainActivity.cs: Updated intent variable name, command message conditional, and local variable names
  • App.xaml.cs: Updated method name, command message sent, and updated logic within timeout method to properly lock/log out when necessary
  • AppDelegate.cs: Updated variable names, command messages received, updated method names and local variable names.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/840 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 4/17/2020 **Status:** ✅ Merged **Merged:** 4/17/2020 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `feature-auto-logout` ← **Head:** `fal-lock-option-refactor` --- ### 📝 Commits (1) - [`98e1a52`](https://github.com/bitwarden/android/commit/98e1a5258a9277e84d2774a1c923f429666369a9) Initial commit: lockOption/lock refactor app layer ### 📊 Changes **3 files changed** (+50 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+9 -9) 📝 `src/App/App.xaml.cs` (+22 -13) 📝 `src/iOS/AppDelegate.cs` (+19 -19) </details> ### 📄 Description ## Objective > Change existing `lockOption` variables, method names, and message commands to use the `...vaultTimeout...` pattern. ## Code Changes - **MainActivity.cs**: Updated intent variable name, command message conditional, and local variable names - **App.xaml.cs**: Updated method name, command message sent, and updated logic within timeout method to properly lock/log out when necessary - **AppDelegate.cs**: Updated variable names, command messages received, updated method names and local variable names. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:39 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2608