github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6570] [MERGED] PM-29867: Fix notifications announcement #26062

New Issue
Closed
opened 2026-04-17 01:36:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 01:36:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6570
Author: @david-livefront
Created: 2/24/2026
Status: ✅ Merged
Merged: 2/24/2026
Merged by: @david-livefront

Base: main ← Head: PM-29867-notification-badge-announcement

📝 Commits (1)

  • b42f6ae PM-29867: Fix notifications announcement

📊 Changes

13 files changed (+63 additions, -60 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreen.kt (+1 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarViewModel.kt (+1 -14)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/model/VaultUnlockedNavBarTab.kt (+0 -4)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreenTest.kt (+1 -7)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarViewModelTest.kt (+1 -10)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/navbar/AuthenticatorNavBarScreen.kt (+0 -2)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/badge/NotificationBadge.kt (+12 -1)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenBottomAppBar.kt (+0 -1)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenNavigationBarItem.kt (+22 -5)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenNavigationRail.kt (+0 -3)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenNavigationRailItem.kt (+21 -4)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/model/NavigationItem.kt (+0 -5)
📝 ui/src/main/res/values/strings.xml (+4 -0)

📄 Description

🎟️ Tracking

PM-29867

📔 Objective

This PR updates the TalkBack announcements for notification badges in the app. This mainly affects the BottomNav and NavigationRail items.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6570 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 2/24/2026 **Status:** ✅ Merged **Merged:** 2/24/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-29867-notification-badge-announcement` --- ### 📝 Commits (1) - [`b42f6ae`](https://github.com/bitwarden/android/commit/b42f6ae22c408b0dffc051ae031483116818d8dd) PM-29867: Fix notifications announcement ### 📊 Changes **13 files changed** (+63 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreen.kt` (+1 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarViewModel.kt` (+1 -14) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/model/VaultUnlockedNavBarTab.kt` (+0 -4) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreenTest.kt` (+1 -7) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarViewModelTest.kt` (+1 -10) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/navbar/AuthenticatorNavBarScreen.kt` (+0 -2) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/badge/NotificationBadge.kt` (+12 -1) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenBottomAppBar.kt` (+0 -1) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenNavigationBarItem.kt` (+22 -5) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenNavigationRail.kt` (+0 -3) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/BitwardenNavigationRailItem.kt` (+21 -4) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/navigation/model/NavigationItem.kt` (+0 -5) 📝 `ui/src/main/res/values/strings.xml` (+4 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-29867](https://bitwarden.atlassian.net/browse/PM-29867) ## 📔 Objective This PR updates the TalkBack announcements for notification badges in the app. This mainly affects the BottomNav and NavigationRail items. [PM-29867]: https://bitwarden.atlassian.net/browse/PM-29867?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 01:36:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#26062
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?