github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6488] [MERGED] [PM-31614] feat: Added new UI for the Email verification on sends #25993

New Issue
Closed
opened 2026-04-17 01:33:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 01:33:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6488
Author: @aj-rosado
Created: 2/6/2026
Status: ✅ Merged
Merged: 2/13/2026
Merged by: @aj-rosado

Base: main ← Head: PM-31614/update-add-edit-send-ui-email-auth

📝 Commits (10+)

  • b6b7002 Added new UI for the Email verification on sends
  • 5dd79bf Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth
  • bc3b881 Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth
  • 107ac9f addressed PR comments
  • 9b0b6af Addressed missing ImmutableList calls and fixed tests
  • c91306b Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth
  • b3053e4 fixed SyncServiceTest
  • c813498 Revert "fixed SyncServiceTest"
  • 8917a9f Changed SendAuthType's SupportingTextRes property to Text
  • daed6db Add SendAuth class that holds data related to send authentication

📊 Changes

14 files changed (+1257 additions, -43 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt (+56 -34)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendViewModel.kt (+134 -1)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt (+160 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/handlers/AddEditSendHandlers.kt (+24 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/model/AuthEmail.kt (+17 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/model/SendAuth.kt (+66 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/AddEditSendStateExtensions.kt (+15 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/SendViewExtensions.kt (+15 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/SendViewUtil.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendScreenTest.kt (+461 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendViewModelTest.kt (+231 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/AddEditSendStateExtensionsTest.kt (+57 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/SendViewExtensionsTest.kt (+13 -2)
📝 ui/src/main/res/values/strings.xml (+7 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31614

📔 Objective

Initial PR to add the layout changes for the Email Verification option on Sends.
The changes are behind a feature flag and should not have any impact when it is turned off.

This does not add the changes to the server and misses validations that will be added on subsequent PRs.

📸 Screenshots

Screenshot_1770402169 Screenshot_1770402172 Screenshot_1770402191 Screenshot_1770402349

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6488 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 2/6/2026 **Status:** ✅ Merged **Merged:** 2/13/2026 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-31614/update-add-edit-send-ui-email-auth` --- ### 📝 Commits (10+) - [`b6b7002`](https://github.com/bitwarden/android/commit/b6b70024c3e5a66a56f1f05baf42bb21a0b2e9be) Added new UI for the Email verification on sends - [`5dd79bf`](https://github.com/bitwarden/android/commit/5dd79bf2bc25911cad9a098651da509c055fc006) Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth - [`bc3b881`](https://github.com/bitwarden/android/commit/bc3b881830a97f7ea71232e1cc4692b063a5f27e) Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth - [`107ac9f`](https://github.com/bitwarden/android/commit/107ac9f3ca92db15ac91ac3bb67bee0c50dce42d) addressed PR comments - [`9b0b6af`](https://github.com/bitwarden/android/commit/9b0b6afbaff1dba03f3815783587bb8de85a4053) Addressed missing ImmutableList calls and fixed tests - [`c91306b`](https://github.com/bitwarden/android/commit/c91306b0f6502d92d515aad247c78579eec1046c) Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth - [`b3053e4`](https://github.com/bitwarden/android/commit/b3053e48d2cedced9f1fa0db861901ee456004f5) fixed SyncServiceTest - [`c813498`](https://github.com/bitwarden/android/commit/c813498484932e2c50c78e5581d23d73aa27fd3f) Revert "fixed SyncServiceTest" - [`8917a9f`](https://github.com/bitwarden/android/commit/8917a9f22c1faa82b16eb0b0bdeab7441b61b403) Changed SendAuthType's SupportingTextRes property to Text - [`daed6db`](https://github.com/bitwarden/android/commit/daed6db06123f55814d148e975708cb874d82571) Add SendAuth class that holds data related to send authentication ### 📊 Changes **14 files changed** (+1257 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt` (+56 -34) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendViewModel.kt` (+134 -1) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt` (+160 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/handlers/AddEditSendHandlers.kt` (+24 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/model/AuthEmail.kt` (+17 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/model/SendAuth.kt` (+66 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/AddEditSendStateExtensions.kt` (+15 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/SendViewExtensions.kt` (+15 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/SendViewUtil.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendScreenTest.kt` (+461 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendViewModelTest.kt` (+231 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/AddEditSendStateExtensionsTest.kt` (+57 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/SendViewExtensionsTest.kt` (+13 -2) 📝 `ui/src/main/res/values/strings.xml` (+7 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-31614 ## 📔 Objective Initial PR to add the layout changes for the Email Verification option on Sends. The changes are behind a feature flag and should not have any impact when it is turned off. This does not add the changes to the server and misses validations that will be added on subsequent PRs. ## 📸 Screenshots <img width="316" alt="Screenshot_1770402169" src="https://github.com/user-attachments/assets/7cf053f2-4002-4c74-ab0f-a018fea2008d" /> <img width="316" alt="Screenshot_1770402172" src="https://github.com/user-attachments/assets/3ac49ba1-208a-4df3-a6d1-0718606da2bd" /> <img width="316" alt="Screenshot_1770402191" src="https://github.com/user-attachments/assets/580977b3-dc36-4cdd-9a01-261a80df4d28" /> <img width="316" alt="Screenshot_1770402349" src="https://github.com/user-attachments/assets/e55d2c38-8087-41d2-b837-45cc80887a51" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 01:33:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#25993
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?