github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6479] [MERGED] Update AGP to v9.0.0 #25987

New Issue
Closed
opened 2026-04-17 01:33:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 01:33:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6479
Author: @david-livefront
Created: 2/4/2026
Status: ✅ Merged
Merged: 2/6/2026
Merged by: @david-livefront

Base: main ← Head: update-agp-without-new-dsl

📝 Commits (1)

📊 Changes

15 files changed (+25 additions, -16 deletions)

View changed files

📝 annotation/build.gradle.kts (+0 -1)
➕ annotation/consumer-rules.pro (+0 -0)
➕ annotation/proguard-rules.pro (+21 -0)
📝 app/build.gradle.kts (+0 -1)
📝 authenticator/build.gradle.kts (+0 -1)
📝 authenticatorbridge/build.gradle.kts (+0 -1)
📝 build.gradle.kts (+0 -1)
📝 core/build.gradle.kts (+0 -1)
📝 cxf/build.gradle.kts (+0 -1)
📝 data/build.gradle.kts (+0 -1)
📝 gradle.properties (+2 -2)
📝 gradle/libs.versions.toml (+2 -3)
📝 network/build.gradle.kts (+0 -1)
📝 testharness/build.gradle.kts (+0 -1)
📝 ui/build.gradle.kts (+0 -1)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR updates the app to use AGP v9.0.0 and Hilt v2.59.

This is a major update to AGP and this PR addresses several changes required to make it all work but there is still some amount of deprecated code that is still in use after this PR is done (baby steps).

  • Removed the Kotlin Android Plugin
  • Updated to Hilt v2.59.1 (Requires AGP 9)
  • Updated gradle.properties to use new default and disable new defaults we are not yet ready for.
    • android.newDsl is currently set to false, this is the biggest one that still requires a lot of work to update.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6479 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 2/4/2026 **Status:** ✅ Merged **Merged:** 2/6/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `update-agp-without-new-dsl` --- ### 📝 Commits (1) - [`ce8cc8b`](https://github.com/bitwarden/android/commit/ce8cc8b025fed788ef67c02bb3b3326deeac8a4e) Update AGP to v9.0.0 ### 📊 Changes **15 files changed** (+25 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `annotation/build.gradle.kts` (+0 -1) ➕ `annotation/consumer-rules.pro` (+0 -0) ➕ `annotation/proguard-rules.pro` (+21 -0) 📝 `app/build.gradle.kts` (+0 -1) 📝 `authenticator/build.gradle.kts` (+0 -1) 📝 `authenticatorbridge/build.gradle.kts` (+0 -1) 📝 `build.gradle.kts` (+0 -1) 📝 `core/build.gradle.kts` (+0 -1) 📝 `cxf/build.gradle.kts` (+0 -1) 📝 `data/build.gradle.kts` (+0 -1) 📝 `gradle.properties` (+2 -2) 📝 `gradle/libs.versions.toml` (+2 -3) 📝 `network/build.gradle.kts` (+0 -1) 📝 `testharness/build.gradle.kts` (+0 -1) 📝 `ui/build.gradle.kts` (+0 -1) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR updates the app to use AGP v9.0.0 and Hilt v2.59. This is a major update to AGP and this PR addresses several changes required to make it all work but there is still some amount of deprecated code that is still in use after this PR is done (baby steps). * Removed the Kotlin Android Plugin * Updated to [Hilt v2.59.1](https://github.com/google/dagger/releases/tag/dagger-2.59.1) (Requires AGP 9) * Updated `gradle.properties` to use new default and disable new defaults we are not yet ready for. * `android.newDsl` is currently set to false, this is the biggest one that still requires a lot of work to update. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 01:33:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#25987
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?