github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-17 10:04:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #800] [MERGED] Changed all C# control flow block statements to include space… #2592

New Issue
Closed
opened 2025-11-26 23:21:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:27 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/800
Author: @cscharf
Created: 3/27/2020
Status: ✅ Merged
Merged: 3/28/2020
Merged by: @cscharf

Base: master ← Head: control-flow-syntax-change

📝 Commits (1)

  • 03e5083 Changed all C# control flow block statements to include space between keyword and open paren

📊 Changes

225 files changed (+2406 additions, -2406 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityActivity.cs (+7 -7)
📝 src/Android/Accessibility/AccessibilityHelpers.cs (+50 -50)
📝 src/Android/Accessibility/AccessibilityService.cs (+50 -50)
📝 src/Android/Accessibility/NodeList.cs (+1 -1)
📝 src/Android/Autofill/AutofillHelpers.cs (+15 -15)
📝 src/Android/Autofill/AutofillService.cs (+11 -11)
📝 src/Android/Autofill/Field.cs (+14 -14)
📝 src/Android/Autofill/FieldCollection.cs (+43 -43)
📝 src/Android/Autofill/FilledItem.cs (+34 -34)
📝 src/Android/Autofill/Parser.cs (+19 -19)
📝 src/Android/Effects/FabShadowEffect.cs (+1 -1)
📝 src/Android/Effects/FixedSizeEffect.cs (+1 -1)
📝 src/Android/Effects/SelectableLabelEffect.cs (+1 -1)
📝 src/Android/Effects/TabBarEffect.cs (+2 -2)
📝 src/Android/MainActivity.cs (+37 -37)
📝 src/Android/MainApplication.cs (+2 -2)
📝 src/Android/Push/FirebaseMessagingService.cs (+3 -3)
📝 src/Android/Receivers/ClearClipboardAlarmReceiver.cs (+1 -1)
📝 src/Android/Receivers/RestrictionsChangedReceiver.cs (+1 -1)
📝 src/Android/Renderers/CipherViewCellRenderer.cs (+13 -13)

...and 80 more files

📄 Description

… between the keyword and open paren

How it was done:
Visual Studio "Replace in Files"
with options:

  • Use Regular Expressions
  • Case Sensitive
  • Look in: Entire solution
  • File types = "*.cs"

Find: ([\s])((switch)|(if)|(for)|(foreach)|(using)|(while)|(catch)|(lock))\(
Replace: $1$2 (

Needed Changes:
On developer machines, under Tools > Settings > Text Editor > C# > Code Style > Formatting > Spacing, need to check "Insert space after keywords in control flow statements".

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/800 **Author:** [@cscharf](https://github.com/cscharf) **Created:** 3/27/2020 **Status:** ✅ Merged **Merged:** 3/28/2020 **Merged by:** [@cscharf](https://github.com/cscharf) **Base:** `master` ← **Head:** `control-flow-syntax-change` --- ### 📝 Commits (1) - [`03e5083`](https://github.com/bitwarden/android/commit/03e5083651df6081b434fb0339f168c46e91c6c5) Changed all C# control flow block statements to include space between keyword and open paren ### 📊 Changes **225 files changed** (+2406 additions, -2406 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityActivity.cs` (+7 -7) 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+50 -50) 📝 `src/Android/Accessibility/AccessibilityService.cs` (+50 -50) 📝 `src/Android/Accessibility/NodeList.cs` (+1 -1) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+15 -15) 📝 `src/Android/Autofill/AutofillService.cs` (+11 -11) 📝 `src/Android/Autofill/Field.cs` (+14 -14) 📝 `src/Android/Autofill/FieldCollection.cs` (+43 -43) 📝 `src/Android/Autofill/FilledItem.cs` (+34 -34) 📝 `src/Android/Autofill/Parser.cs` (+19 -19) 📝 `src/Android/Effects/FabShadowEffect.cs` (+1 -1) 📝 `src/Android/Effects/FixedSizeEffect.cs` (+1 -1) 📝 `src/Android/Effects/SelectableLabelEffect.cs` (+1 -1) 📝 `src/Android/Effects/TabBarEffect.cs` (+2 -2) 📝 `src/Android/MainActivity.cs` (+37 -37) 📝 `src/Android/MainApplication.cs` (+2 -2) 📝 `src/Android/Push/FirebaseMessagingService.cs` (+3 -3) 📝 `src/Android/Receivers/ClearClipboardAlarmReceiver.cs` (+1 -1) 📝 `src/Android/Receivers/RestrictionsChangedReceiver.cs` (+1 -1) 📝 `src/Android/Renderers/CipherViewCellRenderer.cs` (+13 -13) _...and 80 more files_ </details> ### 📄 Description … between the keyword and open paren **How it was done:** Visual Studio "Replace in Files" with options: - Use Regular Expressions - Case Sensitive - Look in: Entire solution - File types = "*.cs" Find: `([\s])((switch)|(if)|(for)|(foreach)|(using)|(while)|(catch)|(lock))\(` Replace: `$1$2 (` Needed Changes: On developer machines, under Tools > Settings > Text Editor > C# > Code Style > Formatting > Spacing, need to check "Insert space after keywords in control flow statements". --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2592
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?