github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #764] [MERGED] Move tab bar colors to styles #2578

New Issue
Closed
opened 2025-11-26 23:21:15 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:15 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/764
Author: @kspearrin
Created: 3/11/2020
Status: ✅ Merged
Merged: 3/11/2020
Merged by: @kspearrin

Base: master ← Head: tabcolorfix

📝 Commits (1)

  • 7fefed7 Move tab bar colors to styles

📊 Changes

3 files changed (+7 additions, -11 deletions)

View changed files

📝 src/App/Pages/TabsPage.cs (+3 -7)
📝 src/App/Styles/Base.xaml (+4 -0)
📝 src/iOS/Renderers/CustomTabbedRenderer.cs (+0 -4)

📄 Description

Looks like the platform-specific property for tab colors was deprecated in Xamarin.Forms 4, so moved this to proper styling (new way) and removed the custom renderer hack on iOS.

Also changed Icon to IconImageSource since apparently that was deprecated now too.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/764 **Author:** [@kspearrin](https://github.com/kspearrin) **Created:** 3/11/2020 **Status:** ✅ Merged **Merged:** 3/11/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `tabcolorfix` --- ### 📝 Commits (1) - [`7fefed7`](https://github.com/bitwarden/android/commit/7fefed768f4fdb403bf830f5f6c4b052dd67cd98) Move tab bar colors to styles ### 📊 Changes **3 files changed** (+7 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/TabsPage.cs` (+3 -7) 📝 `src/App/Styles/Base.xaml` (+4 -0) 📝 `src/iOS/Renderers/CustomTabbedRenderer.cs` (+0 -4) </details> ### 📄 Description Looks like the platform-specific property for tab colors was deprecated in Xamarin.Forms 4, so moved this to proper styling (new way) and removed the custom renderer hack on iOS. Also changed Icon to IconImageSource since apparently that was deprecated now too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:15 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2578
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?