github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #756] [MERGED] Fixed potential broadcast leak & policy value parsing #2574

New Issue
Closed
opened 2025-11-26 23:21:13 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:13 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/756
Author: @mpbw2
Created: 3/5/2020
Status: ✅ Merged
Merged: 3/5/2020
Merged by: @mpbw2

Base: master ← Head: bugfixes

📝 Commits (1)

  • f5774bf Fixed potential broadcast leak & policy value parsing

📊 Changes

2 files changed (+45 additions, -21 deletions)

View changed files

📝 src/App/Pages/Settings/ExportVaultPage.xaml.cs (+2 -1)
📝 src/Core/Services/PasswordGenerationService.cs (+43 -20)

📄 Description

  • Added missing call to Unsubscribe broadcaster service in ExportVaultPage (and fixed copy pasta on Subscribe call)

  • Rewrote policy parser to properly check for existence of key before value retrieval

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/756 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 3/5/2020 **Status:** ✅ Merged **Merged:** 3/5/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfixes` --- ### 📝 Commits (1) - [`f5774bf`](https://github.com/bitwarden/android/commit/f5774bf82e119c02793003b9b3c65ddca35ff774) Fixed potential broadcast leak & policy value parsing ### 📊 Changes **2 files changed** (+45 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/ExportVaultPage.xaml.cs` (+2 -1) 📝 `src/Core/Services/PasswordGenerationService.cs` (+43 -20) </details> ### 📄 Description - Added missing call to Unsubscribe broadcaster service in ExportVaultPage (and fixed copy pasta on Subscribe call) - Rewrote policy parser to properly check for existence of key before value retrieval --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:13 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2574
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?