github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6072] [MERGED] Implement reusable Claude code review workflow #25667

New Issue
Closed
opened 2026-04-17 01:18:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 01:18:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6072
Author: @theMickster
Created: 10/23/2025
Status: ✅ Merged
Merged: 10/27/2025
Merged by: @SaintPatrck

Base: main ← Head: arch/pm-26935/reusable-code-review-workflow

📝 Commits (8)

  • ebc38b4 Implement reusable Claude code review workflow
  • 48e0ce4 Update Claude guidelines for Bitwarden Android
  • b7fb072 Add reviewing-changes skill and streamline docs
  • dec2ed7 Add CODEOWNERS for Claude-related files
  • 9a0bd0b Remove line number references from SKILL.md
  • 60d00cf Add code formatting to file paths and code references
  • 5fde898 Add the claude workflows to code owners
  • 6f297ba Merge branch 'main' into arch/pm-26935/reusable-code-review-workflow

📊 Changes

6 files changed (+288 additions, -0 deletions)

View changed files

➕ .claude/CLAUDE.md (+105 -0)
➕ .claude/prompts/review-code.md (+20 -0)
➕ .claude/skills/reviewing-changes/SKILL.md (+110 -0)
📝 .github/CODEOWNERS (+5 -0)
➕ .github/workflows/respond.yml (+28 -0)
➕ .github/workflows/review-code.yml (+20 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26935

📔 Objective

Establish Claude AI-assisted code review infrastructure for the Bitwarden Android project, including automated workflows, comprehensive development guidelines, and team ownership configuration.

Infrastructure & Automation

  • GitHub Actions workflows (.github/workflows/review-code.yml, .github/workflows/respond.yml) - Automated Claude code review triggers and response handling
    • CODEOWNERS - Routes .claude/ changes to @bitwarden/team-ai-sme

Claude Configuration

  • .claude/CLAUDE.md - Comprehensive guidelines covering:
    • Core directives (architecture adherence, code style, security requirements)
    • Module organization (:core, :data, :network, :ui, :app, :authenticator)
    • MVVM + UDF, Hilt DI, and testing patterns
    • Workflow practices and anti-patterns
  • .claude/skills/reviewing-changes/SKILL.md - Structured code review skill with step-by-step guidance for compliance checks, documentation validation, and feedback generation
  • .claude/prompts/review-code.md - Slash command prompt for initiating code reviews

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6072 **Author:** [@theMickster](https://github.com/theMickster) **Created:** 10/23/2025 **Status:** ✅ Merged **Merged:** 10/27/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `arch/pm-26935/reusable-code-review-workflow` --- ### 📝 Commits (8) - [`ebc38b4`](https://github.com/bitwarden/android/commit/ebc38b4fdc18ba9350f51f2a2b7cbce6637c1cbc) Implement reusable Claude code review workflow - [`48e0ce4`](https://github.com/bitwarden/android/commit/48e0ce4aa57f8c5fa0849f0594dd85998a453018) Update Claude guidelines for Bitwarden Android - [`b7fb072`](https://github.com/bitwarden/android/commit/b7fb0727585a14154fad16fcbb2c5932b13d971b) Add `reviewing-changes` skill and streamline docs - [`dec2ed7`](https://github.com/bitwarden/android/commit/dec2ed71559115c813285064e3e467c1f58dae55) Add CODEOWNERS for Claude-related files - [`9a0bd0b`](https://github.com/bitwarden/android/commit/9a0bd0b371506af2a5eff2b463308e3d8e139b67) Remove line number references from SKILL.md - [`60d00cf`](https://github.com/bitwarden/android/commit/60d00cf4ea47692ab86471bbbf4edaabd917d202) Add code formatting to file paths and code references - [`5fde898`](https://github.com/bitwarden/android/commit/5fde8981463e8a1b6cbaf90fbf6e8ae818ef312b) Add the claude workflows to code owners - [`6f297ba`](https://github.com/bitwarden/android/commit/6f297ba750415dc0b1b704993b55a9a88b06a409) Merge branch 'main' into arch/pm-26935/reusable-code-review-workflow ### 📊 Changes **6 files changed** (+288 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.claude/CLAUDE.md` (+105 -0) ➕ `.claude/prompts/review-code.md` (+20 -0) ➕ `.claude/skills/reviewing-changes/SKILL.md` (+110 -0) 📝 `.github/CODEOWNERS` (+5 -0) ➕ `.github/workflows/respond.yml` (+28 -0) ➕ `.github/workflows/review-code.yml` (+20 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-26935 ## 📔 Objective Establish Claude AI-assisted code review infrastructure for the Bitwarden Android project, including automated workflows, comprehensive development guidelines, and team ownership configuration. ### Infrastructure & Automation - GitHub Actions workflows (.github/workflows/review-code.yml, .github/workflows/respond.yml) - Automated Claude code review triggers and response handling - CODEOWNERS - Routes .claude/ changes to @bitwarden/team-ai-sme ### Claude Configuration - .claude/CLAUDE.md - Comprehensive guidelines covering: - Core directives (architecture adherence, code style, security requirements) - Module organization (:core, :data, :network, :ui, :app, :authenticator) - MVVM + UDF, Hilt DI, and testing patterns - Workflow practices and anti-patterns - .claude/skills/reviewing-changes/SKILL.md - Structured code review skill with step-by-step guidance for compliance checks, documentation validation, and feedback generation - .claude/prompts/review-code.md - Slash command prompt for initiating code reviews ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 01:18:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#25667
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?