github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5967] [MERGED] PM-26358: Integrate the token auth logic with the SDK #25571

New Issue
Closed
opened 2026-04-17 01:13:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 01:13:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5967
Author: @david-livefront
Created: 9/30/2025
Status: ✅ Merged
Merged: 10/7/2025
Merged by: @david-livefront

Base: main ← Head: PM-26358-sdk-auth-token

📝 Commits (1)

  • 3f9b485 PM-26358: Integrate the token auth logic with the SDK

📊 Changes

17 files changed (+403 additions, -139 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/AuthTokenManagerImpl.kt (+13 -12)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManagerImpl.kt (+10 -16)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+2 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactory.kt (+6 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryImpl.kt (+12 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkTokenRepository.kt (+15 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/manager/AuthTokenManagerTest.kt (+129 -48)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryTests.kt (+21 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkTokenRepositoryTest.kt (+57 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/network/di/PlatformNetworkModule.kt (+1 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/manager/SdkClientManagerImpl.kt (+3 -10)
📝 network/src/main/kotlin/com/bitwarden/network/BitwardenServiceClient.kt (+5 -0)
📝 network/src/main/kotlin/com/bitwarden/network/BitwardenServiceClientImpl.kt (+2 -0)
📝 network/src/main/kotlin/com/bitwarden/network/interceptor/AuthTokenManager.kt (+66 -51)
📝 network/src/main/kotlin/com/bitwarden/network/interceptor/AuthTokenProvider.kt (+4 -0)
➕ network/src/main/kotlin/com/bitwarden/network/provider/TokenProvider.kt (+11 -0)
📝 network/src/test/kotlin/com/bitwarden/network/interceptor/AuthTokenManagerTest.kt (+46 -2)

📄 Description

🎟️ Tracking

PM-26358

📔 Objective

This PR creates a bridge between the SDK and the network layer in order to allow the SDK to retrieve an updated auth token.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5967 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 9/30/2025 **Status:** ✅ Merged **Merged:** 10/7/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-26358-sdk-auth-token` --- ### 📝 Commits (1) - [`3f9b485`](https://github.com/bitwarden/android/commit/3f9b485ec676232c82c68ddd6db1f77d096dc487) PM-26358: Integrate the token auth logic with the SDK ### 📊 Changes **17 files changed** (+403 additions, -139 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/AuthTokenManagerImpl.kt` (+13 -12) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/SdkClientManagerImpl.kt` (+10 -16) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+2 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactory.kt` (+6 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryImpl.kt` (+12 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkTokenRepository.kt` (+15 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/manager/AuthTokenManagerTest.kt` (+129 -48) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryTests.kt` (+21 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkTokenRepositoryTest.kt` (+57 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/network/di/PlatformNetworkModule.kt` (+1 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/manager/SdkClientManagerImpl.kt` (+3 -10) 📝 `network/src/main/kotlin/com/bitwarden/network/BitwardenServiceClient.kt` (+5 -0) 📝 `network/src/main/kotlin/com/bitwarden/network/BitwardenServiceClientImpl.kt` (+2 -0) 📝 `network/src/main/kotlin/com/bitwarden/network/interceptor/AuthTokenManager.kt` (+66 -51) 📝 `network/src/main/kotlin/com/bitwarden/network/interceptor/AuthTokenProvider.kt` (+4 -0) ➕ `network/src/main/kotlin/com/bitwarden/network/provider/TokenProvider.kt` (+11 -0) 📝 `network/src/test/kotlin/com/bitwarden/network/interceptor/AuthTokenManagerTest.kt` (+46 -2) </details> ### 📄 Description ## 🎟️ Tracking [PM-26358](https://bitwarden.atlassian.net/browse/PM-26358) ## 📔 Objective This PR creates a bridge between the SDK and the network layer in order to allow the SDK to retrieve an updated auth token. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-26358]: https://bitwarden.atlassian.net/browse/PM-26358?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 01:13:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#25571
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?