github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #709] [MERGED] Accessibility fixes #2552

New Issue
Closed
opened 2025-11-26 23:20:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:20:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/709
Author: @mpbw2
Created: 1/27/2020
Status: ✅ Merged
Merged: 1/27/2020
Merged by: @kspearrin

Base: master ← Head: feature-acc-visibility

📝 Commits (6)

  • 4397ad2 Show/hide accessibility overlay on scroll based on several visibility factors
  • 9911a97 Improvements to accessibility overlay anchor view tracking
  • 931b7e3 Increase recursion limit and check for null children when walking the node tree
  • 34b98d6 Cleanup
  • 7c58732 Hide overlay when expanding status (notification) bar
  • fbfa150 use .Any() instead of .Count()

📊 Changes

3 files changed (+253 additions, -123 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+111 -26)
📝 src/Android/Accessibility/AccessibilityService.cs (+140 -95)
📝 src/Android/Resources/xml/accessibilityservice.xml (+2 -2)

📄 Description

Fixes to accessibility overlay anchor view tracking and node tree parsing. Restricted calls to 'RootInActiveWindow' until absolutely necessary as it can be expensive (this was the culprit behind chromium based browser performance with view tracking).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/709 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 1/27/2020 **Status:** ✅ Merged **Merged:** 1/27/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `feature-acc-visibility` --- ### 📝 Commits (6) - [`4397ad2`](https://github.com/bitwarden/android/commit/4397ad2fdfdc17bb1642929c950f7c114847fb32) Show/hide accessibility overlay on scroll based on several visibility factors - [`9911a97`](https://github.com/bitwarden/android/commit/9911a979f3c9705a9ef037a0c78741d32da24204) Improvements to accessibility overlay anchor view tracking - [`931b7e3`](https://github.com/bitwarden/android/commit/931b7e3664020782f09008ec9481f0946e94ddfe) Increase recursion limit and check for null children when walking the node tree - [`34b98d6`](https://github.com/bitwarden/android/commit/34b98d6406746bcb70c5167f80a86fba73a22aa8) Cleanup - [`7c58732`](https://github.com/bitwarden/android/commit/7c58732f23734cceef8286276184c0c349421af5) Hide overlay when expanding status (notification) bar - [`fbfa150`](https://github.com/bitwarden/android/commit/fbfa15085a39b7f89c4de85e3e364cd35478e735) use .Any() instead of .Count() ### 📊 Changes **3 files changed** (+253 additions, -123 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+111 -26) 📝 `src/Android/Accessibility/AccessibilityService.cs` (+140 -95) 📝 `src/Android/Resources/xml/accessibilityservice.xml` (+2 -2) </details> ### 📄 Description Fixes to accessibility overlay anchor view tracking and node tree parsing. Restricted calls to 'RootInActiveWindow' until absolutely necessary as it can be expensive (this was the culprit behind chromium based browser performance with view tracking). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:20:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2552
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?