github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-17 18:43:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #687] [CLOSED] Better Logout / Login Buttons #2546

New Issue
Closed
opened 2025-11-26 23:20:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:20:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/687
Author: @Max-We
Created: 1/1/2020
Status: ❌ Closed

Base: master ← Head: bitwarden-mobile-menu-adjustments

📝 Commits (1)

  • 9dc42a0 Rearranged Logout / Login Buttons; Added new Logout button to Toolbar in Settings.

📊 Changes

6 files changed (+24 additions, -16 deletions)

View changed files

📝 src/Android/Resources/Resource.designer.cs (+4 -4)
📝 src/App/Pages/Accounts/LockPage.xaml (+2 -2)
📝 src/App/Pages/Settings/SettingsPage/SettingsPage.xaml (+5 -1)
📝 src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs (+9 -4)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+3 -4)
📝 src/App/Resources/AppResources.de.resx (+1 -1)

📄 Description

First off I swapped the Logout and Login Button on the Lock-Page to a more intuitive position. This idea was based on a suggestion I saw on Reddit (sorry forgot username).
Also I changed the Title of the Lock Page to something more fitting in German, as the old Title is too large to fit on the screen (cut off with "...").
Lastly I moved the Logout Button from the Settings into its Toolbar, which makes it a lot quicker to reach and adds consistency with the Lock page.

p.s. This is my first open-source commit and the first time I had to to with Xamarin. Please let me know if there are things I should pay attention to in the future, thank you! I hope you like my changes!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/687 **Author:** [@Max-We](https://github.com/Max-We) **Created:** 1/1/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `bitwarden-mobile-menu-adjustments` --- ### 📝 Commits (1) - [`9dc42a0`](https://github.com/bitwarden/android/commit/9dc42a0941161d524fd2702f6fa2fe0e8a824bf7) Rearranged Logout / Login Buttons; Added new Logout button to Toolbar in Settings. ### 📊 Changes **6 files changed** (+24 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Resources/Resource.designer.cs` (+4 -4) 📝 `src/App/Pages/Accounts/LockPage.xaml` (+2 -2) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPage.xaml` (+5 -1) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPage.xaml.cs` (+9 -4) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+3 -4) 📝 `src/App/Resources/AppResources.de.resx` (+1 -1) </details> ### 📄 Description First off I swapped the Logout and Login Button on the Lock-Page to a more intuitive position. This idea was based on a suggestion I saw on Reddit (sorry forgot username). Also I changed the Title of the Lock Page to something more fitting in German, as the old Title is too large to fit on the screen (cut off with "..."). Lastly I moved the Logout Button from the Settings into its Toolbar, which makes it a lot quicker to reach and adds consistency with the Lock page. p.s. This is my first open-source commit and the first time I had to to with Xamarin. Please let me know if there are things I should pay attention to in the future, thank you! I hope you like my changes! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:20:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2546
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?