github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #686] [MERGED] Change password generator to use ColoredPassword #2545

New Issue
Closed
opened 2025-11-26 23:20:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:20:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/686
Author: @devsecdan
Created: 1/1/2020
Status: ✅ Merged
Merged: 1/3/2020
Merged by: @kspearrin

Base: master ← Head: Fix-GeneratorColoredPassword

📝 Commits (5)

  • e97c604 Change password generator to use ColoredPassword
  • ecda1c9 Change ColoredPassword from FormattedString to HTML string for improved performance
  • 1ef96b0 PasswordFormatter fixes
  • 621249e Correct || to && condition
  • c3ea122 Apply password colouring to history pages

📊 Changes

7 files changed (+64 additions, -16 deletions)

View changed files

📝 src/App/Pages/Generator/GeneratorHistoryPage.xaml (+3 -1)
📝 src/App/Pages/Generator/GeneratorPage.xaml (+2 -1)
📝 src/App/Pages/Generator/GeneratorPageViewModel.cs (+1 -1)
📝 src/App/Pages/Vault/PasswordHistoryPage.xaml (+3 -1)
📝 src/App/Pages/Vault/ViewPage.xaml (+2 -1)
➕ src/App/Utilities/ColoredPasswordConverter.cs (+28 -0)
📝 src/App/Utilities/PasswordFormatter.cs (+25 -11)

📄 Description

Passwords displayed in the password generator are not colour coded like they are on other platforms. This pull request changes the password generator password to be colour coded.

https://community.bitwarden.com/t/color-coded-password-not-working-on-android/9594

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/686 **Author:** [@devsecdan](https://github.com/devsecdan) **Created:** 1/1/2020 **Status:** ✅ Merged **Merged:** 1/3/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `Fix-GeneratorColoredPassword` --- ### 📝 Commits (5) - [`e97c604`](https://github.com/bitwarden/android/commit/e97c60418a61bd2892e31a4f8a13efc89076a1ff) Change password generator to use ColoredPassword - [`ecda1c9`](https://github.com/bitwarden/android/commit/ecda1c9ae7e068d11844aa4523930d071b57f2a8) Change ColoredPassword from FormattedString to HTML string for improved performance - [`1ef96b0`](https://github.com/bitwarden/android/commit/1ef96b0ec518fdf6dad45db95d14b9c42f3862e4) PasswordFormatter fixes - [`621249e`](https://github.com/bitwarden/android/commit/621249e8d47516802d3acb087540d9a06a1e9d4d) Correct || to && condition - [`c3ea122`](https://github.com/bitwarden/android/commit/c3ea12264758d0278f6b22729307c4418be49be4) Apply password colouring to history pages ### 📊 Changes **7 files changed** (+64 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Generator/GeneratorHistoryPage.xaml` (+3 -1) 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+2 -1) 📝 `src/App/Pages/Generator/GeneratorPageViewModel.cs` (+1 -1) 📝 `src/App/Pages/Vault/PasswordHistoryPage.xaml` (+3 -1) 📝 `src/App/Pages/Vault/ViewPage.xaml` (+2 -1) ➕ `src/App/Utilities/ColoredPasswordConverter.cs` (+28 -0) 📝 `src/App/Utilities/PasswordFormatter.cs` (+25 -11) </details> ### 📄 Description Passwords displayed in the password generator are not colour coded like they are on other platforms. This pull request changes the password generator password to be colour coded. https://community.bitwarden.com/t/color-coded-password-not-working-on-android/9594 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:20:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2545
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?