github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5654] [MERGED] [PM-24411] Introduce BuildInfoManager for build-related information #25320

New Issue
Closed
opened 2026-04-17 01:01:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 01:01:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5654
Author: @SaintPatrck
Created: 8/6/2025
Status: ✅ Merged
Merged: 8/6/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-24411/build-info-manager

📝 Commits (1)

  • 31b0441 [PM-24411] Introduce BuildInfoManager for build-related information

📊 Changes

6 files changed (+208 additions, -1 deletions)

View changed files

➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/BitwardenBuildInfoManagerImpl.kt (+42 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/di/PlatformUiManagerModule.kt (+7 -1)
📝 authenticator/build.gradle.kts (+23 -0)
➕ authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/manager/AuthenticatorBuildInfoManagerImpl.kt (+47 -0)
➕ core/src/main/kotlin/com/bitwarden/core/data/manager/BuildInfoManager.kt (+51 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/manager/util/BuildInfoManagerExtensions.kt (+38 -0)

📄 Description

🎟️ Tracking

PM-24411

📔 Objective

This commit introduces a BuildInfoManager interface and its implementations to centralize access to build-specific information across different Bitwarden client applications.

Key changes:

  • Added BuildInfoManager interface in the ui module to define a contract for accessing build details like application ID, flavor, build type, version, and CI information.
  • Created BitwardenBuildInfoManagerImpl in the app module, providing the implementation for the Bitwarden Password Manager, sourcing data from its BuildConfig.
  • Created AuthenticatorBuildInfoManagerImpl in the authenticator module, providing the implementation for Bitwarden Authenticator, sourcing data from its BuildConfig.
  • Added BuildInfoManagerExtensions.kt in the ui module, offering convenient extension properties for formatted device, OS, and build information, and FileProvider authority.
  • Updated PlatformUiManagerModule in the app module to provide BuildInfoManager as a singleton dependency.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5654 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 8/6/2025 **Status:** ✅ Merged **Merged:** 8/6/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-24411/build-info-manager` --- ### 📝 Commits (1) - [`31b0441`](https://github.com/bitwarden/android/commit/31b04415a350f74b2205834585cbcfa25cbb2003) [PM-24411] Introduce BuildInfoManager for build-related information ### 📊 Changes **6 files changed** (+208 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/BitwardenBuildInfoManagerImpl.kt` (+42 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/di/PlatformUiManagerModule.kt` (+7 -1) 📝 `authenticator/build.gradle.kts` (+23 -0) ➕ `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/manager/AuthenticatorBuildInfoManagerImpl.kt` (+47 -0) ➕ `core/src/main/kotlin/com/bitwarden/core/data/manager/BuildInfoManager.kt` (+51 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/manager/util/BuildInfoManagerExtensions.kt` (+38 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-24411 ## 📔 Objective This commit introduces a `BuildInfoManager` interface and its implementations to centralize access to build-specific information across different Bitwarden client applications. Key changes: - Added `BuildInfoManager` interface in the `ui` module to define a contract for accessing build details like application ID, flavor, build type, version, and CI information. - Created `BitwardenBuildInfoManagerImpl` in the `app` module, providing the implementation for the Bitwarden Password Manager, sourcing data from its `BuildConfig`. - Created `AuthenticatorBuildInfoManagerImpl` in the `authenticator` module, providing the implementation for Bitwarden Authenticator, sourcing data from its `BuildConfig`. - Added `BuildInfoManagerExtensions.kt` in the `ui` module, offering convenient extension properties for formatted device, OS, and build information, and FileProvider authority. - Updated `PlatformUiManagerModule` in the `app` module to provide `BuildInfoManager` as a singleton dependency. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 01:01:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#25320
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?