github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5520] [MERGED] [PM-23696] Hide cards from export when policy is enabled. #25216

New Issue
Closed
opened 2026-04-17 00:55:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 00:55:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5520
Author: @andrebispo5
Created: 7/11/2025
Status: ✅ Merged
Merged: 7/15/2025
Merged by: @andrebispo5

Base: main ← Head: pm-23696/restricted-items-export

📝 Commits (5)

  • 93cc596 [PM-23696] Hide cards from export when policy is enabled.
  • 0ec7205 Merge branch 'main' into pm-23696/restricted-items-export
  • a874ee6 [PM-23696] Fix failing test due to missing mock
  • 68f8cbc [PM-23696] Add missing test.
  • b3ae3a4 [PM-23696] Add missing parameter names to test mock

📊 Changes

5 files changed (+187 additions, -11 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt (+8 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+9 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultViewModel.kt (+23 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+63 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultViewModelTest.kt (+84 -4)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23696

📔 Objective

When restricted item types policy is enabled, the credit card item(s), which are hidden in the UI, should not be exported/shouldn’t be included in the json data.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5520 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 7/11/2025 **Status:** ✅ Merged **Merged:** 7/15/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-23696/restricted-items-export` --- ### 📝 Commits (5) - [`93cc596`](https://github.com/bitwarden/android/commit/93cc596a838fb41e88f0deb312517affe1adc52e) [PM-23696] Hide cards from export when policy is enabled. - [`0ec7205`](https://github.com/bitwarden/android/commit/0ec720508f8304d42fafbebd2324c287f38a4a5e) Merge branch 'main' into pm-23696/restricted-items-export - [`a874ee6`](https://github.com/bitwarden/android/commit/a874ee691608bba16ece32181d25870389034b20) [PM-23696] Fix failing test due to missing mock - [`68f8cbc`](https://github.com/bitwarden/android/commit/68f8cbc0a29f126b9e3d92fe4f44b5ed9e8c91aa) [PM-23696] Add missing test. - [`b3ae3a4`](https://github.com/bitwarden/android/commit/b3ae3a441765bddc8593ce8cea0b3d9e5bdb600d) [PM-23696] Add missing parameter names to test mock ### 📊 Changes **5 files changed** (+187 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt` (+8 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+9 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultViewModel.kt` (+23 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+63 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultViewModelTest.kt` (+84 -4) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-23696 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> When restricted item types policy is enabled, the credit card item(s), which are hidden in the UI, should not be exported/shouldn’t be included in the json data. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 00:55:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#25216
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?