[PR #420] [MERGED] Honor user CA store when targeting Android Nougat SDK and later #2498

Closed
opened 2025-11-26 23:20:13 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/420
Author: @dnetguru
Created: 12/1/2018
Status: Merged
Merged: 12/2/2018
Merged by: @kspearrin

Base: masterHead: master


📝 Commits (3)

  • e94810d Included network-security-config.xml file to honor user added CAs (see:
  • 77288a3 Added domain-config entry to only use system CAs connecting to bitwarden.com
  • 7058ee2 Deny all plaintext traffic from network_security_config

📊 Changes

4 files changed (+26 additions, -1 deletions)

View changed files

📝 src/Android/Android.csproj (+3 -0)
📝 src/Android/Properties/AndroidManifest.xml (+2 -1)
📝 src/Android/Resources/Resource.Designer.cs (+3 -0)
src/Android/Resources/xml/network_security_config.xml (+18 -0)

📄 Description

See: https://android-developers.googleblog.com/2016/07/changes-to-trusted-certificate.html

Fixes: #346


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/420 **Author:** [@dnetguru](https://github.com/dnetguru) **Created:** 12/1/2018 **Status:** ✅ Merged **Merged:** 12/2/2018 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`e94810d`](https://github.com/bitwarden/android/commit/e94810d9d71429a35af8967c29d870a26177e374) Included network-security-config.xml file to honor user added CAs (see: - [`77288a3`](https://github.com/bitwarden/android/commit/77288a3b27070dbc84b668db6fb2121c294d351c) Added domain-config entry to only use system CAs connecting to bitwarden.com - [`7058ee2`](https://github.com/bitwarden/android/commit/7058ee297125bfbf9428424528d95fc2c03a4b37) Deny all plaintext traffic from network_security_config ### 📊 Changes **4 files changed** (+26 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+3 -0) 📝 `src/Android/Properties/AndroidManifest.xml` (+2 -1) 📝 `src/Android/Resources/Resource.Designer.cs` (+3 -0) ➕ `src/Android/Resources/xml/network_security_config.xml` (+18 -0) </details> ### 📄 Description See: https://android-developers.googleblog.com/2016/07/changes-to-trusted-certificate.html Fixes: #346 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:20:13 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2498