github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 06:04:20 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #328] [MERGED] Card Security Code masked (bitwarden/desktop issue 78) #2481

New Issue
Closed
opened 2025-11-26 23:20:00 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:20:00 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/328
Author: @neilsb
Created: 6/16/2018
Status: ✅ Merged
Merged: 6/18/2018
Merged by: @kspearrin

Base: master ← Head: master

📝 Commits (2)

  • 3db8625 Card Security Code masked in the same way as Passwords. (bitwarden/desktop issue 78)
  • 4d26e50 Creating property to store value of Masked Card Code Shown

📊 Changes

4 files changed (+51 additions, -6 deletions)

View changed files

📝 src/App/Models/Page/VaultViewCipherPageModel.cs (+17 -0)
📝 src/App/Pages/Vault/VaultAddCipherPage.cs (+10 -2)
📝 src/App/Pages/Vault/VaultEditCipherPage.cs (+16 -1)
📝 src/App/Pages/Vault/VaultViewCipherPage.cs (+8 -3)

📄 Description

By default shows Card Security Code masked in the same way as Passwords. (bitwarden/desktop issue 78)

Only tested on Android (not iOS devices available) but when setting input field to password, the keyboard type of "Numeric" isn't honoured and it shows standard keyboard with numbers at the top. Tested this is new project and the same thing happens.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/328 **Author:** [@neilsb](https://github.com/neilsb) **Created:** 6/16/2018 **Status:** ✅ Merged **Merged:** 6/18/2018 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`3db8625`](https://github.com/bitwarden/android/commit/3db86250b99dbd6009d5edfdd99372f3f6abbe29) Card Security Code masked in the same way as Passwords. (bitwarden/desktop issue 78) - [`4d26e50`](https://github.com/bitwarden/android/commit/4d26e50ad2b24c1871853c19a948e944ff86497d) Creating property to store value of Masked Card Code Shown ### 📊 Changes **4 files changed** (+51 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Models/Page/VaultViewCipherPageModel.cs` (+17 -0) 📝 `src/App/Pages/Vault/VaultAddCipherPage.cs` (+10 -2) 📝 `src/App/Pages/Vault/VaultEditCipherPage.cs` (+16 -1) 📝 `src/App/Pages/Vault/VaultViewCipherPage.cs` (+8 -3) </details> ### 📄 Description By default shows Card Security Code masked in the same way as Passwords. (bitwarden/desktop issue 78) Only tested on Android (not iOS devices available) but when setting input field to password, the keyboard type of "Numeric" isn't honoured and it shows standard keyboard with numbers at the top. Tested this is new project and the same thing happens. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:20:00 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2481
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?