github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 06:04:20 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #293] [MERGED] Don't leak password length through mask #2477

New Issue
Closed
opened 2025-11-26 23:19:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:19:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/293
Author: @mpcsh
Created: 3/6/2018
Status: ✅ Merged
Merged: 3/6/2018
Merged by: @kspearrin

Base: master ← Head: master

📝 Commits (1)

  • 6346542 Don't leak password length through mask

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/App/Models/Page/VaultViewCipherPageModel.cs (+2 -2)

📄 Description

This is a pretty simple PR. I'm migrating from 1Password to Bitwarden, and I noticed that while 1Password has a constant-length password mask, Bitwarden's leaks the length of the password even when it's masked. This commit simply changes to a constant-length mask.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/293 **Author:** [@mpcsh](https://github.com/mpcsh) **Created:** 3/6/2018 **Status:** ✅ Merged **Merged:** 3/6/2018 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`6346542`](https://github.com/bitwarden/android/commit/6346542722bdf9e55cfcc1045e4a3fb18bdd8e88) Don't leak password length through mask ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Models/Page/VaultViewCipherPageModel.cs` (+2 -2) </details> ### 📄 Description This is a pretty simple PR. I'm migrating from 1Password to Bitwarden, and I noticed that while 1Password has a constant-length password mask, Bitwarden's leaks the length of the password even when it's masked. This commit simply changes to a constant-length mask. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:19:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2477
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?