[PR #212] [MERGED] Add support for Windows Hello #2457

Closed
opened 2025-11-26 23:19:41 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/212
Author: @alistair23
Created: 12/15/2017
Status: Merged
Merged: 12/15/2017
Merged by: @kspearrin

Base: masterHead: alistair/fingerprint


📝 Commits (1)

  • 4118cb4 Add support for Windows Hello

📊 Changes

5 files changed (+57 additions, -5 deletions)

View changed files

📝 src/App/Pages/Lock/LockFingerprintPage.cs (+18 -4)
📝 src/App/Pages/Settings/SettingsPage.cs (+2 -1)
📝 src/App/Resources/AppResources.Designer.cs (+27 -0)
📝 src/App/Resources/AppResources.resx (+9 -0)
📝 src/UWP.Images/UWP.Images.projitems (+1 -0)

📄 Description

Windows Hello is currently supported in the UWP app, but all of the
strings just point to using fingerprint. Windows Hello instead will
adjust based on what the user has avaliable and registered with the
Windows OS. To reflect that it isn't just fingerprints update the
strings when on UWP.

Signed-off-by: Alistair Francis alistair@alistair23.me


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/212 **Author:** [@alistair23](https://github.com/alistair23) **Created:** 12/15/2017 **Status:** ✅ Merged **Merged:** 12/15/2017 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `alistair/fingerprint` --- ### 📝 Commits (1) - [`4118cb4`](https://github.com/bitwarden/android/commit/4118cb498099debd3d19980b586e758c6ffe6d28) Add support for Windows Hello ### 📊 Changes **5 files changed** (+57 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Lock/LockFingerprintPage.cs` (+18 -4) 📝 `src/App/Pages/Settings/SettingsPage.cs` (+2 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+27 -0) 📝 `src/App/Resources/AppResources.resx` (+9 -0) 📝 `src/UWP.Images/UWP.Images.projitems` (+1 -0) </details> ### 📄 Description Windows Hello is currently supported in the UWP app, but all of the strings just point to using fingerprint. Windows Hello instead will adjust based on what the user has avaliable and registered with the Windows OS. To reflect that it isn't just fingerprints update the strings when on UWP. Signed-off-by: Alistair Francis <alistair@alistair23.me> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:19:41 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2457