github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #193] [MERGED] Login page fixes #2447

New Issue
Closed
opened 2025-11-26 23:19:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:19:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/193
Author: @alistair23
Created: 12/2/2017
Status: ✅ Merged
Merged: 12/6/2017
Merged by: @kspearrin

Base: master ← Head: alistair/login-fixes

📝 Commits (2)

  • ff68da6 App: LoginPage.cs: Correct the Windows device specifier
  • 16fe996 App: LoginPage.cs: Fix the FormEntryCell imageSource

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 src/App/Pages/LoginPage.cs (+4 -4)

📄 Description

This series provides a lot of fixes for Windows 10 and Windows Phone 10 UWP platforms.

This sets the toolbar options to have images (otherwise they look blank on the default view). See https://github.com/bitwarden/mobile/pull/188 for what the difference is.

This also fixes up the layout to correctly separate the login boxes (they used to be touching) and ensures that the reset password link can be seen by the user.

It fixes up some missing images.

Finally it allows the back button to appear when running on Windows 10. Previously it would not appear and there would be no obvious way to progress backwards. This allows us to remove the cancel button.

I'm getting the hang of this now, so if this is merged I can keep working on the other pages.

This is what it looks like now:
Phone
windowsphone-uwp-login
Desktop
windows10-uwp-login

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/193 **Author:** [@alistair23](https://github.com/alistair23) **Created:** 12/2/2017 **Status:** ✅ Merged **Merged:** 12/6/2017 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `alistair/login-fixes` --- ### 📝 Commits (2) - [`ff68da6`](https://github.com/bitwarden/android/commit/ff68da678bc22535bd6c32039d06fa00a66f7d7e) App: LoginPage.cs: Correct the Windows device specifier - [`16fe996`](https://github.com/bitwarden/android/commit/16fe9967acfea774e3b88e4bc1d72c052b5acfb0) App: LoginPage.cs: Fix the FormEntryCell imageSource ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/LoginPage.cs` (+4 -4) </details> ### 📄 Description This series provides a lot of fixes for Windows 10 and Windows Phone 10 UWP platforms. This sets the toolbar options to have images (otherwise they look blank on the default view). See https://github.com/bitwarden/mobile/pull/188 for what the difference is. This also fixes up the layout to correctly separate the login boxes (they used to be touching) and ensures that the reset password link can be seen by the user. It fixes up some missing images. Finally it allows the back button to appear when running on Windows 10. Previously it would not appear and there would be no obvious way to progress backwards. This allows us to remove the cancel button. I'm getting the hang of this now, so if this is merged I can keep working on the other pages. This is what it looks like now: Phone ![windowsphone-uwp-login](https://user-images.githubusercontent.com/171674/33519805-34e44b22-d763-11e7-9642-66cd56f2d964.PNG) Desktop <img width="610" alt="windows10-uwp-login" src="https://user-images.githubusercontent.com/171674/33519806-34fd7ad4-d763-11e7-8051-c8b6a07c4c43.PNG"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:19:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2447
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?