github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-16 23:25:17 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3623] [MERGED] PM-9135: Update host matching to include optional port value #23671

New Issue
Closed
opened 2026-04-16 23:41:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:41:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3623
Author: @david-livefront
Created: 7/24/2024
Status: ✅ Merged
Merged: 7/26/2024
Merged by: @david-livefront

Base: main ← Head: update-host-matching

📝 Commits (1)

  • 022eb1c Update host matching to include optional port value

📊 Changes

3 files changed (+20 additions, -10 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/ciphermatching/CipherMatchingManagerImpl.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/util/StringExtensions.kt (+12 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/ciphermatching/CipherMatchingManagerTest.kt (+5 -5)

📄 Description

🎟️ Tracking

PM-9135
https://github.com/bitwarden/android/issues/3341

📔 Objective

This PR adds back port matching to the Host matching logic, the main difference between this implementation and the original is that the port is now an optional property instead of a required property.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3623 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 7/24/2024 **Status:** ✅ Merged **Merged:** 7/26/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `update-host-matching` --- ### 📝 Commits (1) - [`022eb1c`](https://github.com/bitwarden/android/commit/022eb1c31be4132b0b21f39aa124e62f9c154112) Update host matching to include optional port value ### 📊 Changes **3 files changed** (+20 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/ciphermatching/CipherMatchingManagerImpl.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/util/StringExtensions.kt` (+12 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/ciphermatching/CipherMatchingManagerTest.kt` (+5 -5) </details> ### 📄 Description ## 🎟️ Tracking [PM-9135](https://bitwarden.atlassian.net/browse/PM-9135) https://github.com/bitwarden/android/issues/3341 ## 📔 Objective This PR adds back port matching to the Host matching logic, the main difference between this implementation and the original is that the port is now an optional property instead of a required property. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-9135]: https://bitwarden.atlassian.net/browse/PM-9135?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:41:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23671
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?