github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 15:09:35 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3617] [MERGED] [PM-6702] 1# Add service calls for email verification #23665

New Issue
Closed
opened 2026-04-16 23:41:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:41:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3617
Author: @andrebispo5
Created: 7/23/2024
Status: ✅ Merged
Merged: 8/9/2024
Merged by: @andrebispo5

Base: main ← Head: pm-6702/evf-service-calls

📝 Commits (10+)

  • 764c0a3 [PM-6702] Send verification email service
  • b1d0053 [PM-6702] Register finish service call
  • 5356dff [PM-6702] Add service tests
  • 8127d60 Merge branch 'main' into pm-6702/evf-service-calls
  • c9c35e8 Merge branch 'main' into pm-6702/evf-service-calls
  • 9b7f790 [PM-6702] Code format
  • d0783b3 [PM-6702] Change service calls and tests to use new retrofit null body handling
  • a96e95a [PM-6702] Change service return from String to PrimitiveJson
  • 6fccb35 [PM-6702] Code format
  • 001483a [PM-6702] Move string parsing to service

📊 Changes

11 files changed (+526 additions, -52 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/IdentityApi.kt (+13 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/RegisterFinishRequestJson.kt (+64 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/SendVerificationEmailRequestJson.kt (+23 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/SendVerificationEmailResponseJson.kt (+47 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/service/IdentityService.kt (+14 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/service/IdentityServiceImpl.kt (+45 -10)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt (+11 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+59 -14)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/SendVerificationEmailResult.kt (+22 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/network/service/IdentityServiceTest.kt (+120 -28)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+108 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-6702

📔 Objective

Add SendVerificationEmail and RegisterFinish service calls to be used in email verification feature.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3617 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 7/23/2024 **Status:** ✅ Merged **Merged:** 8/9/2024 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-6702/evf-service-calls` --- ### 📝 Commits (10+) - [`764c0a3`](https://github.com/bitwarden/android/commit/764c0a3901cdf4f6f542cf6cbcfef835c16f6275) [PM-6702] Send verification email service - [`b1d0053`](https://github.com/bitwarden/android/commit/b1d0053393606e4da1513dbcf7b1f1a006ed4755) [PM-6702] Register finish service call - [`5356dff`](https://github.com/bitwarden/android/commit/5356dffe25c4b536b688e9444dfce72df96880da) [PM-6702] Add service tests - [`8127d60`](https://github.com/bitwarden/android/commit/8127d6093337e3f1daaa6469a8e1bf39ba1ea1bd) Merge branch 'main' into pm-6702/evf-service-calls - [`c9c35e8`](https://github.com/bitwarden/android/commit/c9c35e8ec4ef688578f0f2bfa8b94806c44c9e4d) Merge branch 'main' into pm-6702/evf-service-calls - [`9b7f790`](https://github.com/bitwarden/android/commit/9b7f7900fc6c0d31c88e2a47f4ce8fd0153fc443) [PM-6702] Code format - [`d0783b3`](https://github.com/bitwarden/android/commit/d0783b31926183336bef3cc5c002f50fa2c1286d) [PM-6702] Change service calls and tests to use new retrofit null body handling - [`a96e95a`](https://github.com/bitwarden/android/commit/a96e95a2ace7ebf1dd5c6e3e684e22b6dbec1751) [PM-6702] Change service return from String to PrimitiveJson - [`6fccb35`](https://github.com/bitwarden/android/commit/6fccb358e98071cfb8cead91d70f546abbb98ab4) [PM-6702] Code format - [`001483a`](https://github.com/bitwarden/android/commit/001483a11539332952e2978b1785ce084d932120) [PM-6702] Move string parsing to service ### 📊 Changes **11 files changed** (+526 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/IdentityApi.kt` (+13 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/RegisterFinishRequestJson.kt` (+64 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/SendVerificationEmailRequestJson.kt` (+23 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/SendVerificationEmailResponseJson.kt` (+47 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/service/IdentityService.kt` (+14 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/service/IdentityServiceImpl.kt` (+45 -10) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt` (+11 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+59 -14) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/SendVerificationEmailResult.kt` (+22 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/network/service/IdentityServiceTest.kt` (+120 -28) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+108 -0) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-6702 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Add `SendVerificationEmail` and `RegisterFinish` service calls to be used in email verification feature. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:41:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23665