github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3344] [MERGED] Append 'Json' suffix to network model name #23532

New Issue
Closed
opened 2026-04-16 23:34:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:34:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3344
Author: @david-livefront
Created: 6/24/2024
Status: ✅ Merged
Merged: 6/24/2024
Merged by: @david-livefront

Base: main ← Head: append-json-to-network-model-name

📝 Commits (1)

  • 9640139 Append 'Json' suffix to network model name

📊 Changes

10 files changed (+25 additions, -25 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/EventDiskSource.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/EventDiskSourceImpl.kt (+4 -4)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/api/EventApi.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/model/OrganizationEventJson.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/service/EventService.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/service/EventServiceImpl.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/event/OrganizationEventManagerImpl.kt (+2 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/disk/EventDiskSourceTest.kt (+3 -3)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/service/EventServiceTest.kt (+2 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/event/OrganizationEventManagerTest.kt (+4 -4)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR renames a network model to include the Json suffix.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3344 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 6/24/2024 **Status:** ✅ Merged **Merged:** 6/24/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `append-json-to-network-model-name` --- ### 📝 Commits (1) - [`9640139`](https://github.com/bitwarden/android/commit/9640139f1ecfb9d8a4f22989540120c22658b7e3) Append 'Json' suffix to network model name ### 📊 Changes **10 files changed** (+25 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/EventDiskSource.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/EventDiskSourceImpl.kt` (+4 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/api/EventApi.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/model/OrganizationEventJson.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/service/EventService.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/network/service/EventServiceImpl.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/event/OrganizationEventManagerImpl.kt` (+2 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/disk/EventDiskSourceTest.kt` (+3 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/service/EventServiceTest.kt` (+2 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/event/OrganizationEventManagerTest.kt` (+4 -4) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR renames a network model to include the `Json` suffix. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:34:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23532
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?