github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 08:09:16 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #3148] [MERGED] [PM-7369] Show passkey icon on android when the item has a Fido2 credential #23429

New Issue
Closed
opened 2026-04-16 23:30:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:30:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3148
Author: @dinisvieira
Created: 4/10/2024
Status: ✅ Merged
Merged: 4/11/2024
Merged by: @dinisvieira

Base: feature/maui-migration-passkeys ← Head: bug/PM-7369-show-passkey-icon-android

📝 Commits (4)

  • 3993cc4 PM-7369 Show passkey icon on android when the item has a Fido2 credential
  • a17286a PM-7369 alternative way to show passkey icon only in scenarios where we are trying to create a passkey
  • 8756f7c PM-7369 moved logic to show passkey icon to CipherItemViewModel
  • e259875 Update src/Core/Utilities/IconGlyphConverter.cs

📊 Changes

6 files changed (+19 additions, -7 deletions)

View changed files

📝 src/Core/Controls/CipherViewCell/CipherViewCell.xaml (+1 -1)
📝 src/Core/Models/View/CipherView.cs (+1 -1)
📝 src/Core/Pages/Vault/AutofillCiphersPageViewModel.cs (+5 -1)
📝 src/Core/Pages/Vault/CipherItemViewModel.cs (+2 -0)
📝 src/Core/Utilities/IconGlyphConverter.cs (+6 -0)
📝 src/Core/Utilities/IconGlyphExtensions.cs (+4 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Android is not showing passkey icon when "show website icons" is disabled

Code changes

Changed IconGlyphExtensions to take into account if the cipher has Fido2Credential and return passkey icon in that scenario.

  • IconGlyphExtensions.cs:

Screenshots

Before After
Screenshot_1712768117 Screenshot_1712767855

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3148 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 4/10/2024 **Status:** ✅ Merged **Merged:** 4/11/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `feature/maui-migration-passkeys` ← **Head:** `bug/PM-7369-show-passkey-icon-android` --- ### 📝 Commits (4) - [`3993cc4`](https://github.com/bitwarden/android/commit/3993cc464c2a37d68558a7d35e0c883bc9d8fd2c) PM-7369 Show passkey icon on android when the item has a Fido2 credential - [`a17286a`](https://github.com/bitwarden/android/commit/a17286a62fb96700d2d3c6698f4f57e191c4f7a4) PM-7369 alternative way to show passkey icon only in scenarios where we are trying to create a passkey - [`8756f7c`](https://github.com/bitwarden/android/commit/8756f7c0e6611d5ad4ec975056f454867188ab17) PM-7369 moved logic to show passkey icon to CipherItemViewModel - [`e259875`](https://github.com/bitwarden/android/commit/e2598754e4c2a17f441c5e456845c294630fbf6b) Update src/Core/Utilities/IconGlyphConverter.cs ### 📊 Changes **6 files changed** (+19 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Controls/CipherViewCell/CipherViewCell.xaml` (+1 -1) 📝 `src/Core/Models/View/CipherView.cs` (+1 -1) 📝 `src/Core/Pages/Vault/AutofillCiphersPageViewModel.cs` (+5 -1) 📝 `src/Core/Pages/Vault/CipherItemViewModel.cs` (+2 -0) 📝 `src/Core/Utilities/IconGlyphConverter.cs` (+6 -0) 📝 `src/Core/Utilities/IconGlyphExtensions.cs` (+4 -4) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Android is not showing passkey icon when "show website icons" is disabled ## Code changes Changed IconGlyphExtensions to take into account if the cipher has Fido2Credential and return passkey icon in that scenario. * **IconGlyphExtensions.cs:** ## Screenshots Before | After :-------------------------:|:-------------------------: ![Screenshot_1712768117](https://github.com/bitwarden/mobile/assets/2824952/0d83f975-62bd-4762-aa1c-99b330b20ee3) | ![Screenshot_1712767855](https://github.com/bitwarden/mobile/assets/2824952/ddab0c83-70d4-4644-9a79-18112ab2288b) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:30:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23429
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?