github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-19 07:55:46 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #3117] [MERGED] [PM-6538][PM-7185] Remove Non-Discoverable filter for passkeys when setting the credentials on the ASStore #23411

New Issue
Closed
opened 2026-04-16 23:29:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:29:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3117
Author: @fedemkr
Created: 3/26/2024
Status: ✅ Merged
Merged: 3/27/2024
Merged by: @vvolkgang

Base: feature/maui-migration-passkeys ← Head: vault/pm-6538/fix-shopify-autofill

📝 Commits (1)

  • 9945239 PM-6538 Removed non-discoverable passkeys filter for credentials that go to the ASStore

📊 Changes

1 file changed (+0 additions, -5 deletions)

View changed files

📝 src/iOS.Core/Utilities/ASHelpers.cs (+0 -5)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Remove Non-Discoverable filter for passkeys when setting the credentials on the ASStore to see if that fixes some sites not displaying the passkey for quick OS bottom sheet selection.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3117 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/26/2024 **Status:** ✅ Merged **Merged:** 3/27/2024 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `feature/maui-migration-passkeys` ← **Head:** `vault/pm-6538/fix-shopify-autofill` --- ### 📝 Commits (1) - [`9945239`](https://github.com/bitwarden/android/commit/9945239244f1d0e3799036256ab95581be878c47) PM-6538 Removed non-discoverable passkeys filter for credentials that go to the ASStore ### 📊 Changes **1 file changed** (+0 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Utilities/ASHelpers.cs` (+0 -5) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Remove Non-Discoverable filter for passkeys when setting the credentials on the ASStore to see if that fixes some sites not displaying the passkey for quick OS bottom sheet selection. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:29:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?