github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2873] [MERGED] [PM-4857] Hide "Allow screen capture" on iOS #23235

New Issue
Closed
opened 2026-04-16 23:22:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:22:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2873
Author: @fedemkr
Created: 11/17/2023
Status: ✅ Merged
Merged: 11/17/2023
Merged by: @fedemkr

Base: master ← Head: PM-4857-hide-screen-capture-toggle-on-ios

📝 Commits (4)

  • 683c7fd PM-4857 Hide "Allow screen capture" on iOS
  • b8e508a PM-4857 Try to fix FDroid build by forcing .NET 7
  • fabb94b PM-4857 Try to fix FDroid build by forcing .NET 7, adding rollForward and disable allowPrerelease to the global json
  • ade4584 PM-4857 Changed global.json to use 7.0.400 so FDroid pass in CI

📊 Changes

2 files changed (+8 additions, -0 deletions)

View changed files

➕ global.json (+7 -0)
📝 src/App/Pages/Settings/OtherSettingsPage.xaml (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Hide "Allow screen capture" on iOS given that it should be only available on Android.

Code changes

  • OtherSettingsPage: Hide toggle for screen capture on iOS

Screenshots

Other settings Android

Other settings Android

Other settings iOS

Other settings iOS

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2873 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 11/17/2023 **Status:** ✅ Merged **Merged:** 11/17/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `PM-4857-hide-screen-capture-toggle-on-ios` --- ### 📝 Commits (4) - [`683c7fd`](https://github.com/bitwarden/android/commit/683c7fd7eb0ca0629add532b101b926991b14286) PM-4857 Hide "Allow screen capture" on iOS - [`b8e508a`](https://github.com/bitwarden/android/commit/b8e508af478a9ed68b938d9b9b8b5f538d627685) PM-4857 Try to fix FDroid build by forcing .NET 7 - [`fabb94b`](https://github.com/bitwarden/android/commit/fabb94bf0bc64cbad2d09b3e88cb0912e92954cb) PM-4857 Try to fix FDroid build by forcing .NET 7, adding rollForward and disable allowPrerelease to the global json - [`ade4584`](https://github.com/bitwarden/android/commit/ade4584e5141652a0ac8c15625914d5faca9451c) PM-4857 Changed global.json to use 7.0.400 so FDroid pass in CI ### 📊 Changes **2 files changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `global.json` (+7 -0) 📝 `src/App/Pages/Settings/OtherSettingsPage.xaml` (+1 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Hide "Allow screen capture" on iOS given that it should be only available on Android. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **OtherSettingsPage:** Hide toggle for screen capture on iOS ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ### Other settings Android <img width="314" alt="Other settings Android" src="https://github.com/bitwarden/mobile/assets/15682323/63fe16d2-9e6b-4bf4-8ab0-485fc7ccc241"> ### Other settings iOS <img width="314" alt="Other settings iOS" src="https://github.com/bitwarden/mobile/assets/15682323/b9bc97cc-ac0a-44f5-971a-90537bba609a "> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:22:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23235
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?