github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2837] [MERGED] [PM-3273][PM-4679] New owner/admin permission on login #23216

New Issue
Closed
opened 2026-04-16 23:21:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:21:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2837
Author: @andrebispo5
Created: 10/23/2023
Status: ✅ Merged
Merged: 11/9/2023
Merged by: @andrebispo5

Base: master ← Head: auth/pm-3273/priv-elevation

📝 Commits (10+)

  • 2908ebb [PM-3273] Add property for password set. Add labels. Update sync service.
  • 47a016d Merge branch 'master' into auth/pm-3273/priv-elevation
  • 123a425 [PM-3273] Set password needs set in state. Read value on sync and nav to page.
  • ed2927d [PM-3273] Add navigation to Set Password on vault landing if needed.
  • 0bdbc2e [PM-3273] Update SetPasswordPage copy
  • 364d64f [PM-3273] Add ManageResetPassword to Org Permissions, handle it on sync.
  • c761e0b [PM-3273] Change user has master password state when set master password is complete.
  • cc8bdf1 [PM-3273] Code clean up
  • 7f65546 Merge branch 'master' into auth/pm-3273/priv-elevation
  • fc6e1ab [PM-3273] code format

📊 Changes

42 files changed (+203544 additions, -33 deletions)

View changed files

📝 src/App/App.xaml.cs (+5 -0)
📝 src/App/Pages/Accounts/LoginSsoPageViewModel.cs (+6 -7)
📝 src/App/Pages/Accounts/SetPasswordPage.xaml (+1 -1)
📝 src/App/Pages/Accounts/SetPasswordPageViewModel.cs (+37 -11)
📝 src/App/Pages/Accounts/TwoFactorPageViewModel.cs (+7 -8)
📝 src/App/Pages/TabsPage.cs (+32 -3)
📝 src/App/Resources/AppResources.Designer.cs (+18 -0)
📝 src/App/Resources/AppResources.cs.Designer.cs (+7821 -0)
📝 src/App/Resources/AppResources.da.Designer.cs (+7822 -0)
📝 src/App/Resources/AppResources.de.Designer.cs (+7821 -0)
📝 src/App/Resources/AppResources.es.Designer.cs (+7823 -0)
📝 src/App/Resources/AppResources.fi.Designer.cs (+7823 -0)
📝 src/App/Resources/AppResources.fr.Designer.cs (+7823 -0)
📝 src/App/Resources/AppResources.hi.Designer.cs (+7823 -0)
📝 src/App/Resources/AppResources.hr.Designer.cs (+7820 -0)
📝 src/App/Resources/AppResources.hu.Designer.cs (+7821 -0)
📝 src/App/Resources/AppResources.id.Designer.cs (+7822 -0)
📝 src/App/Resources/AppResources.it.Designer.cs (+7822 -0)
📝 src/App/Resources/AppResources.ja.Designer.cs (+7822 -0)
📝 src/App/Resources/AppResources.nl.Designer.cs (+7822 -0)

...and 22 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When a user has it's privileges elevated to owner/admin, the user has to set a password.

Code changes

Set ForcePasswordResetReason on login, check and launch a modal to set a password if needed on landing page. The user will be always prompted for a password set until the user has set it.
Since we can't get the decryption option until the next login, we have to set the HasMasterPassword property manually in state for the current session.

Screenshots

https://github.com/bitwarden/mobile/assets/4648522/3bd4b352-0879-4373-8da1-533d057a99e6

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2837 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 10/23/2023 **Status:** ✅ Merged **Merged:** 11/9/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `auth/pm-3273/priv-elevation` --- ### 📝 Commits (10+) - [`2908ebb`](https://github.com/bitwarden/android/commit/2908ebb39323ca53d5183ea007da8f0b139a68db) [PM-3273] Add property for password set. Add labels. Update sync service. - [`47a016d`](https://github.com/bitwarden/android/commit/47a016df02dcfa980d6121f77b429e2d4d622e67) Merge branch 'master' into auth/pm-3273/priv-elevation - [`123a425`](https://github.com/bitwarden/android/commit/123a425cc45e71d70708d77e8508762dbada7c52) [PM-3273] Set password needs set in state. Read value on sync and nav to page. - [`ed2927d`](https://github.com/bitwarden/android/commit/ed2927dc268616d3ec48766cd8a49d0cea323609) [PM-3273] Add navigation to Set Password on vault landing if needed. - [`0bdbc2e`](https://github.com/bitwarden/android/commit/0bdbc2e99365da7dca60c0d95ed82cea23b882ac) [PM-3273] Update SetPasswordPage copy - [`364d64f`](https://github.com/bitwarden/android/commit/364d64f3dc48fd66932b0b84ef8906c2d37765f0) [PM-3273] Add ManageResetPassword to Org Permissions, handle it on sync. - [`c761e0b`](https://github.com/bitwarden/android/commit/c761e0b64872d3f9db5481324b6dce2dc8e2bd85) [PM-3273] Change user has master password state when set master password is complete. - [`cc8bdf1`](https://github.com/bitwarden/android/commit/cc8bdf194eeeb96135a3aa4b29246fabebe7259f) [PM-3273] Code clean up - [`7f65546`](https://github.com/bitwarden/android/commit/7f6554612f96bc2a66cfdd42621d1a88d4cd0a26) Merge branch 'master' into auth/pm-3273/priv-elevation - [`fc6e1ab`](https://github.com/bitwarden/android/commit/fc6e1abd9954b63c46c7a19e77975de2db11e0ae) [PM-3273] code format ### 📊 Changes **42 files changed** (+203544 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+5 -0) 📝 `src/App/Pages/Accounts/LoginSsoPageViewModel.cs` (+6 -7) 📝 `src/App/Pages/Accounts/SetPasswordPage.xaml` (+1 -1) 📝 `src/App/Pages/Accounts/SetPasswordPageViewModel.cs` (+37 -11) 📝 `src/App/Pages/Accounts/TwoFactorPageViewModel.cs` (+7 -8) 📝 `src/App/Pages/TabsPage.cs` (+32 -3) 📝 `src/App/Resources/AppResources.Designer.cs` (+18 -0) 📝 `src/App/Resources/AppResources.cs.Designer.cs` (+7821 -0) 📝 `src/App/Resources/AppResources.da.Designer.cs` (+7822 -0) 📝 `src/App/Resources/AppResources.de.Designer.cs` (+7821 -0) 📝 `src/App/Resources/AppResources.es.Designer.cs` (+7823 -0) 📝 `src/App/Resources/AppResources.fi.Designer.cs` (+7823 -0) 📝 `src/App/Resources/AppResources.fr.Designer.cs` (+7823 -0) 📝 `src/App/Resources/AppResources.hi.Designer.cs` (+7823 -0) 📝 `src/App/Resources/AppResources.hr.Designer.cs` (+7820 -0) 📝 `src/App/Resources/AppResources.hu.Designer.cs` (+7821 -0) 📝 `src/App/Resources/AppResources.id.Designer.cs` (+7822 -0) 📝 `src/App/Resources/AppResources.it.Designer.cs` (+7822 -0) 📝 `src/App/Resources/AppResources.ja.Designer.cs` (+7822 -0) 📝 `src/App/Resources/AppResources.nl.Designer.cs` (+7822 -0) _...and 22 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> When a user has it's privileges elevated to owner/admin, the user has to set a password. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Set `ForcePasswordResetReason` on login, check and launch a modal to set a password if needed on landing page. The user will be always prompted for a password set until the user has set it. Since we can't get the decryption option until the next login, we have to set the `HasMasterPassword` property manually in state for the current session. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> https://github.com/bitwarden/mobile/assets/4648522/3bd4b352-0879-4373-8da1-533d057a99e6 ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:21:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23216
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?