github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-11-10 01:15:13 -06:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2718] [MERGED] [PM-3551] Expired SSO token cached #23144

New Issue
Closed
opened 2026-04-16 23:17:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:17:52 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2718
Author: @andrebispo5
Created: 8/24/2023
Status: ✅ Merged
Merged: 9/8/2023
Merged by: @andrebispo5

Base: master ← Head: auth/pm-3551/expire-sso

📝 Commits (2)

  • 7b87ed1 [PM-3551] Prefer ephemeral web browser session if user cancels the sso flow.
  • 302e192 Update src/App/Pages/Accounts/LoginSsoPageViewModel.cs

📊 Changes

1 file changed (+9 additions, -3 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginSsoPageViewModel.cs (+9 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix bug where an expired sso token is cached by the mobile browser and the user cannot continue the sso login flow.

Code changes

When a user cancels the modal, we will start a cached cleared browser session to login.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2718 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 8/24/2023 **Status:** ✅ Merged **Merged:** 9/8/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `auth/pm-3551/expire-sso` --- ### 📝 Commits (2) - [`7b87ed1`](https://github.com/bitwarden/android/commit/7b87ed1a725247dd1ebebf14e49d4dca59d11226) [PM-3551] Prefer ephemeral web browser session if user cancels the sso flow. - [`302e192`](https://github.com/bitwarden/android/commit/302e1923746c8cb82912758db8ca4fe00da318b6) Update src/App/Pages/Accounts/LoginSsoPageViewModel.cs ### 📊 Changes **1 file changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginSsoPageViewModel.cs` (+9 -3) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix bug where an expired sso token is cached by the mobile browser and the user cannot continue the sso login flow. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> When a user cancels the modal, we will start a cached cleared browser session to login. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:17:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23144