github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2611] [CLOSED] PM-171 remove confirmation alert for restore item click in trash #23057

New Issue
Closed
opened 2026-04-16 23:13:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:13:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2611
Author: @Jingo88
Created: 7/12/2023
Status: ❌ Closed

Base: main ← Head: PM-171-remove-restore-confirm-alert

📝 Commits (10+)

  • c7e9f30 [SG-703] Login request is not removed after dismissing push notification (#2134)
  • a72a0ec Fix autobump workflow (#2138)
  • d18efde updated version bump + crowdin-pull workflows (#2119)
  • eefc9bd [SG-705] Popup when a request for authentication comes in on a logged-in account that is not active (#2135)
  • 4c2f5c0 [PS-1188] Add new Solarized Dark Theme (#2141)
  • 3cb9f37 Autosync the updated translations (#2146)
  • 505426c [SG 547] Mobile username generator iOS.Extension UI changes (#2140)
  • 5deba15 Updated avatar color selection logic (#2151)
  • 4fcb063 Move renovate.json to .github folder (#2152)
  • 77d8afc added missing id check to obj comparison (#2154)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • [ X ] Other

Objective

Removing the confirmation alert for restoring an item from Trash

Confirmation alerts should only be used as warnings if something is being deleted or for irreversible actions. Restoring an item does not fall under this definition.

Code changes

Removed confirmation alert lines for restore inside src/App/Pages/Vault/CipherDetailsPageViewModel.cs

Screenshots

https://github.com/bitwarden/mobile/assets/8302660/0e7a738f-4dcd-446c-b9f2-3dc32a65cdfe

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2611 **Author:** [@Jingo88](https://github.com/Jingo88) **Created:** 7/12/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `PM-171-remove-restore-confirm-alert` --- ### 📝 Commits (10+) - [`c7e9f30`](https://github.com/bitwarden/android/commit/c7e9f30a9a57fc64b700fc26f33ced1eaef2053c) [SG-703] Login request is not removed after dismissing push notification (#2134) - [`a72a0ec`](https://github.com/bitwarden/android/commit/a72a0ec0ce04c888fb57d9b190f9e336ebfdc706) Fix autobump workflow (#2138) - [`d18efde`](https://github.com/bitwarden/android/commit/d18efdea738defa94268a81269daf317cc92d0f0) updated version bump + crowdin-pull workflows (#2119) - [`eefc9bd`](https://github.com/bitwarden/android/commit/eefc9bd2399003a0b23d414566e04a3dbb02b8f3) [SG-705] Popup when a request for authentication comes in on a logged-in account that is not active (#2135) - [`4c2f5c0`](https://github.com/bitwarden/android/commit/4c2f5c05e5d564c1269a5c6b0bf7fd3471cdfe45) [PS-1188] Add new Solarized Dark Theme (#2141) - [`3cb9f37`](https://github.com/bitwarden/android/commit/3cb9f37997bd11cfdf4f80aa0b87bc4ac0ee22bd) Autosync the updated translations (#2146) - [`505426c`](https://github.com/bitwarden/android/commit/505426cd6af6a7584b8c25788f543e18a1c438e8) [SG 547] Mobile username generator iOS.Extension UI changes (#2140) - [`5deba15`](https://github.com/bitwarden/android/commit/5deba15373ce8d8451e6d0580fac407c0c45a2cb) Updated avatar color selection logic (#2151) - [`4fcb063`](https://github.com/bitwarden/android/commit/4fcb063190cc5c5daeae6f108c68a9a661ebf4e4) Move renovate.json to .github folder (#2152) - [`77d8afc`](https://github.com/bitwarden/android/commit/77d8afcfe60592991ac650daaebcc461906b5c82) added missing id check to obj comparison (#2154) ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ X ] Other ## Objective Removing the confirmation alert for restoring an item from Trash Confirmation alerts should only be used as warnings if something is being deleted or for irreversible actions. Restoring an item does not fall under this definition. ## Code changes Removed confirmation alert lines for restore inside `src/App/Pages/Vault/CipherDetailsPageViewModel.cs` ## Screenshots https://github.com/bitwarden/mobile/assets/8302660/0e7a738f-4dcd-446c-b9f2-3dc32a65cdfe ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:13:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23057
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?