github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 15:58:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2367] [MERGED] [PS-2486] Finally stop filling password into username field #22901

New Issue
Closed
opened 2026-04-16 23:08:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:08:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2367
Author: @larena1
Created: 2/13/2023
Status: ✅ Merged
Merged: 3/10/2023
Merged by: @aj-rosado

Base: master ← Head: finally-stop-filling-password-into-username-field

📝 Commits (4)

  • 8577765 Finally stop filling password into username field
  • c4790eb Add TextVariationEmailAddress
  • 95f5a1c Remove
  • 31b6927 Merge branch 'master' into finally-stop-filling-password-into-username-field

📊 Changes

1 file changed (+8 additions, -3 deletions)

View changed files

📝 src/Android/Autofill/FieldCollection.cs (+8 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The logic in #2331 is unfortunately not very reliable as it'll only detect fields that have one of "email", "phone" or "username" in their id as username fields.
This PR ensures that additonally fields that have TextVariationWebEmailAddress are also detected as username fields.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2367 **Author:** [@larena1](https://github.com/larena1) **Created:** 2/13/2023 **Status:** ✅ Merged **Merged:** 3/10/2023 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `finally-stop-filling-password-into-username-field` --- ### 📝 Commits (4) - [`8577765`](https://github.com/bitwarden/android/commit/85777656684e2b8eb2bd004187ef17002ca6f19a) Finally stop filling password into username field - [`c4790eb`](https://github.com/bitwarden/android/commit/c4790eb78e9789272beeea26c1d14a510ac008e8) Add TextVariationEmailAddress - [`95f5a1c`](https://github.com/bitwarden/android/commit/95f5a1ce09bb57ed39c31f2df949c2d22ec7d41d) Remove - [`31b6927`](https://github.com/bitwarden/android/commit/31b69271a97c0ccc89c785cf4ddc7bfb74831c93) Merge branch 'master' into finally-stop-filling-password-into-username-field ### 📊 Changes **1 file changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Autofill/FieldCollection.cs` (+8 -3) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> The logic in #2331 is unfortunately not very reliable as it'll only detect fields that have one of "email", "phone" or "username" in their id as username fields. This PR ensures that additonally fields that have TextVariationWebEmailAddress are also detected as username fields. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:08:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#22901
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?