github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2140] [MERGED] [SG 547] Mobile username generator iOS.Extension UI changes #22760

New Issue
Closed
opened 2026-04-16 23:02:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:02:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2140
Author: @LRNcardozoWDF
Created: 10/18/2022
Status: ✅ Merged
Merged: 10/25/2022
Merged by: @LRNcardozoWDF

Base: master ← Head: feature/SG-547-mobile-username-generator-ios-extension-UI-changes

📝 Commits (10+)

  • ec243bd [SG-547] - Added button to generate username when using iOS extension
  • 2ddeb31 [SG-547] - Missing changes from last commit
  • 27ad701 Merge branch 'master' into feature/SG-547-mobile-username-generator-ios-extension-UI-changes
  • bb2e0f5 Merge branch 'master' into feature/SG-547-mobile-username-generator-ios-extension-UI-changes
  • dc4939d SG-547 - Added missing interface method
  • 4e6bcd8 SG-547 - Added token renovation for iOS.Extension flow
  • 4671e03 SG-547 Replaced generate buttons for icons
  • af38386 Merge branch 'master' into feature/SG-547-mobile-username-generator-ios-extension-UI-changes
  • 8acef97 SG-547 Removed unnecessary validation
  • d84d2dc SG-547 - Fixed PR comments

📊 Changes

12 files changed (+178 additions, -74 deletions)

View changed files

📝 src/Android/Services/DeviceActionService.cs (+6 -0)
📝 src/App/Abstractions/IDeviceActionService.cs (+1 -0)
📝 src/App/Pages/Generator/GeneratorPage.xaml (+1 -1)
📝 src/App/Pages/Generator/GeneratorPage.xaml.cs (+4 -10)
📝 src/App/Pages/Generator/GeneratorPageViewModel.cs (+24 -2)
📝 src/Core/Abstractions/ITokenService.cs (+1 -0)
📝 src/Core/Services/TokenService.cs (+5 -0)
📝 src/iOS.Core/Controllers/BaseLockPasswordViewController.cs (+2 -9)
📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+2 -8)
📝 src/iOS.Core/Controllers/LoginAddViewController.cs (+49 -26)
📝 src/iOS.Core/Services/DeviceActionService.cs (+5 -0)
📝 src/iOS.Core/Views/FormEntryTableViewCell.cs (+78 -18)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add the username generator feature to iOS.Extension

Code changes

  • IDeviceActionService.cs
    Android/Services/DeviceActionService.cs
    iOS.Core/Services/DeviceActionService.cs :     Added support to close new modal pop up.
  • ITokenService.cs
    TokenService.cs :     Added new method to refresh token without returning it.
  • GeneratorPage.xaml.cs : Added flag to identify iOS.Extension flow and support to close a Xamarin.Forms page as View Controller.
  • GeneratorPageViewModel.cs : Made sure token is refreshed before using it to get user's email.
  • LoginAddViewController.cs : Refactored button for generate password, added button for generate username that performs navigation to Username Generator page. Added button eye/eye slash to control password field visibility.
  • FormEntryTableViewCell.cs : Added configuration for a second button and adjusted size when the second button is enabled.

Screenshots

Add item page in iOS.Extension:

Before
image

Now
image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2140 **Author:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Created:** 10/18/2022 **Status:** ✅ Merged **Merged:** 10/25/2022 **Merged by:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Base:** `master` ← **Head:** `feature/SG-547-mobile-username-generator-ios-extension-UI-changes` --- ### 📝 Commits (10+) - [`ec243bd`](https://github.com/bitwarden/android/commit/ec243bd78527deb8d9153efe788a882707ad7b86) [SG-547] - Added button to generate username when using iOS extension - [`2ddeb31`](https://github.com/bitwarden/android/commit/2ddeb31dcb54bf0b67c64058b8655e21c8ef8dbf) [SG-547] - Missing changes from last commit - [`27ad701`](https://github.com/bitwarden/android/commit/27ad701ae237b2250f70d6d306d4592e483b5f69) Merge branch 'master' into feature/SG-547-mobile-username-generator-ios-extension-UI-changes - [`bb2e0f5`](https://github.com/bitwarden/android/commit/bb2e0f5e2f605a5183cf5e042140e39fb33186b1) Merge branch 'master' into feature/SG-547-mobile-username-generator-ios-extension-UI-changes - [`dc4939d`](https://github.com/bitwarden/android/commit/dc4939d9901f29e64ac89a32f9647285155c2d23) SG-547 - Added missing interface method - [`4e6bcd8`](https://github.com/bitwarden/android/commit/4e6bcd88057766bbd7be38d4907ec0e30f54c522) SG-547 - Added token renovation for iOS.Extension flow - [`4671e03`](https://github.com/bitwarden/android/commit/4671e0397f14810a6530ca7db2cceef769d23fff) SG-547 Replaced generate buttons for icons - [`af38386`](https://github.com/bitwarden/android/commit/af38386414836645ea8a6c3e20163ba69b782414) Merge branch 'master' into feature/SG-547-mobile-username-generator-ios-extension-UI-changes - [`8acef97`](https://github.com/bitwarden/android/commit/8acef97559e3793092560b545fe9813a2ca86d06) SG-547 Removed unnecessary validation - [`d84d2dc`](https://github.com/bitwarden/android/commit/d84d2dccbfed9c48a6854990f4024b5122316477) SG-547 - Fixed PR comments ### 📊 Changes **12 files changed** (+178 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/DeviceActionService.cs` (+6 -0) 📝 `src/App/Abstractions/IDeviceActionService.cs` (+1 -0) 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+1 -1) 📝 `src/App/Pages/Generator/GeneratorPage.xaml.cs` (+4 -10) 📝 `src/App/Pages/Generator/GeneratorPageViewModel.cs` (+24 -2) 📝 `src/Core/Abstractions/ITokenService.cs` (+1 -0) 📝 `src/Core/Services/TokenService.cs` (+5 -0) 📝 `src/iOS.Core/Controllers/BaseLockPasswordViewController.cs` (+2 -9) 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+2 -8) 📝 `src/iOS.Core/Controllers/LoginAddViewController.cs` (+49 -26) 📝 `src/iOS.Core/Services/DeviceActionService.cs` (+5 -0) 📝 `src/iOS.Core/Views/FormEntryTableViewCell.cs` (+78 -18) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Add the username generator feature to iOS.Extension ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **IDeviceActionService.cs Android/Services/DeviceActionService.cs iOS.Core/Services/DeviceActionService.cs :** Added support to close new modal pop up. * **ITokenService.cs TokenService.cs :** Added new method to refresh token without returning it. * **GeneratorPage.xaml.cs :** Added flag to identify iOS.Extension flow and support to close a Xamarin.Forms page as View Controller. * **GeneratorPageViewModel.cs :** Made sure token is refreshed before using it to get user's email. * **LoginAddViewController.cs :** Refactored button for generate password, added button for generate username that performs navigation to Username Generator page. Added button eye/eye slash to control password field visibility. * **FormEntryTableViewCell.cs :** Added configuration for a second button and adjusted size when the second button is enabled. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> Add item page in iOS.Extension: **Before** <img width="419" alt="image" src="https://user-images.githubusercontent.com/6855596/196398786-191495ce-dc71-46f4-b47c-fc22c64f9508.jpeg" style="max-width: 100%;"> **Now** <img width="419" alt="image" src="https://user-images.githubusercontent.com/6855596/196393768-c7a46343-3012-43bf-a993-dfb398e31eeb.jpeg" style="max-width: 100%;"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:02:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#22760
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?