github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 00:28:29 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #2001] [MERGED] [PS-686] Change disabled/enabled to on/off #22663

New Issue
Closed
opened 2026-04-16 23:00:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:00:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2001
Author: @coroiu
Created: 7/21/2022
Status: ✅ Merged
Merged: 7/21/2022
Merged by: @coroiu

Base: master ← Head: PS-686-change-to-on-off

📝 Commits (1)

  • 136e4e3 feat: change to on and off

📊 Changes

4 files changed (+1364 additions, -3367 deletions)

View changed files

📝 src/App/Pages/Settings/SettingsPage/SettingsPageListItem.cs (+1 -1)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+5 -5)
📝 src/App/Resources/AppResources.Designer.cs (+1351 -3360)
📝 src/App/Resources/AppResources.resx (+7 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Change disabled/enabled to on/off

Code changes

  • AppResources.resx Translations
  • SettingsPageViewModel.cs Dynamic translation labels
  • SettingsPageListItem.cs Match new labels to correct color

Screenshots

image image

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2001 **Author:** [@coroiu](https://github.com/coroiu) **Created:** 7/21/2022 **Status:** ✅ Merged **Merged:** 7/21/2022 **Merged by:** [@coroiu](https://github.com/coroiu) **Base:** `master` ← **Head:** `PS-686-change-to-on-off` --- ### 📝 Commits (1) - [`136e4e3`](https://github.com/bitwarden/android/commit/136e4e3ed7039c46d8f1203cf375b7919a3ea0f7) feat: change to on and off ### 📊 Changes **4 files changed** (+1364 additions, -3367 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageListItem.cs` (+1 -1) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+5 -5) 📝 `src/App/Resources/AppResources.Designer.cs` (+1351 -3360) 📝 `src/App/Resources/AppResources.resx` (+7 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [x] Other ## Objective Change disabled/enabled to on/off ## Code changes * **AppResources.resx** Translations * **SettingsPageViewModel.cs** Dynamic translation labels * **SettingsPageListItem.cs** Match new labels to correct color ## Screenshots <img align="left" width="300" alt="image" src="https://user-images.githubusercontent.com/2285588/180173667-fec6620a-14a5-4e09-a0b1-0d3d40a4e143.png"> <img width="300" alt="image" src="https://user-images.githubusercontent.com/2285588/180174520-29e24137-027f-427b-867f-987c8da798b6.png"> ## Before you submit - [x] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:00:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#22663
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?