github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-13 23:31:21 -05:00
Code Issues 1.1k Packages Projects Releases 124 Wiki Activity

[PR #1830] [MERGED] fix for logging out active account from switcher and cleanup #22540

New Issue
Closed
opened 2026-04-16 22:54:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 22:54:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1830
Author: @mpbw2
Created: 3/7/2022
Status: ✅ Merged
Merged: 3/7/2022
Merged by: @mpbw2

Base: master ← Head: accountswitching-activelogout

📝 Commits (1)

  • 6899323 fix for logging out active account from switcher and cleanup

📊 Changes

6 files changed (+38 additions, -42 deletions)

View changed files

📝 src/App/App.xaml.cs (+10 -15)
📝 src/App/Utilities/AppHelpers.cs (+8 -1)
📝 src/Core/Abstractions/IStateService.cs (+1 -1)
📝 src/Core/Services/StateService.cs (+1 -1)
📝 src/Core/Services/VaultTimeoutService.cs (+14 -20)
📝 src/Core/Utilities/ServiceContainer.cs (+4 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

  • Fixed an issue where logging out the active account from the switcher menu removed the data but left the current screen in place (instead of switching to another user or showing the home screen if there was only one user)
  • Also made some changes requested in #1826 (will add comments inline on that PR shortly)

Code changes

  • AppHelpers.cs: Added logout message for handling logging out of active account
  • StateService.cs: Added Async suffix to IsActiveAccount method name
  • App.xaml.cs/VaultTimeoutService.cs/ServiceContainer.cs: cleanup (see other PR linked above)

Testing requirements

Perform a logout on the active (current) account via long-press in the account switching menu and observe behavior

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1830 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 3/7/2022 **Status:** ✅ Merged **Merged:** 3/7/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `accountswitching-activelogout` --- ### 📝 Commits (1) - [`6899323`](https://github.com/bitwarden/android/commit/689932334dd26485ebe56a060b2e33e1db198b59) fix for logging out active account from switcher and cleanup ### 📊 Changes **6 files changed** (+38 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+10 -15) 📝 `src/App/Utilities/AppHelpers.cs` (+8 -1) 📝 `src/Core/Abstractions/IStateService.cs` (+1 -1) 📝 `src/Core/Services/StateService.cs` (+1 -1) 📝 `src/Core/Services/VaultTimeoutService.cs` (+14 -20) 📝 `src/Core/Utilities/ServiceContainer.cs` (+4 -4) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> - Fixed an issue where logging out the active account from the switcher menu removed the data but left the current screen in place (instead of switching to another user or showing the home screen if there was only one user) - Also made some changes requested in #1826 (will add comments inline on that PR shortly) ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AppHelpers.cs:** Added logout message for handling logging out of active account * **StateService.cs:** Added `Async` suffix to `IsActiveAccount` method name * **App.xaml.cs/VaultTimeoutService.cs/ServiceContainer.cs:** cleanup (see other PR linked above) ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> Perform a logout on the active (current) account via long-press in the account switching menu and observe behavior ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 22:54:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#22540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?