[PR #1744] [MERGED] set background of biometricCell from theme #22469

Closed
opened 2026-04-16 22:52:07 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1744
Author: @jlf0dev
Created: 1/31/2022
Status: ✅ Merged
Merged: 1/31/2022
Merged by: @vvolkgang

Base: master ← Head: bug/autofill-background-color


📝 Commits (1)

  • 2152f43 set background of biometricCell from theme

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The biometric cell of the Autofill screen was not being updated to the current theme. This fix is fixin to fix it.

Code changes

  • src/iOS.Core/Controllers/LockPasswordViewController.cs: Set theme background on bio cell init

Screenshots

Before:

After:

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1744 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 1/31/2022 **Status:** ✅ Merged **Merged:** 1/31/2022 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `master` ← **Head:** `bug/autofill-background-color` --- ### 📝 Commits (1) - [`2152f43`](https://github.com/bitwarden/android/commit/2152f43182bafee8cc87d40660ee396b56eaa880) set background of biometricCell from theme ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+1 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> The biometric cell of the Autofill screen was not being updated to the current theme. This fix is fixin to fix it. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/iOS.Core/Controllers/LockPasswordViewController.cs:** Set theme background on bio cell init ## Screenshots <!--Required for any UI changes. Delete if not applicable--> Before: <img src="https://user-images.githubusercontent.com/24985544/151865726-27f3613e-63e0-4477-abd8-70ff1893ea96.PNG" height="400"/> After: <img src="https://user-images.githubusercontent.com/24985544/151865934-bf157e34-e229-4b1c-a725-0c4c91b9ba93.PNG" height="400"/> ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 22:52:07 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#22469