github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #1617] [MERGED] remove numeric restriction on card number field #22384

New Issue
Closed
opened 2026-04-16 22:49:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 22:49:14 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1617
Author: @mpbw2
Created: 10/28/2021
Status: ✅ Merged
Merged: 10/28/2021
Merged by: @mpbw2

Base: master ← Head: bugfix-ccnumalpha

📝 Commits (1)

  • a687efb remove numeric restriction on cc number field

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 src/App/Pages/Vault/AddEditPage.xaml (+0 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Remove numeric restriction on card number field that was originally removed here but inadvertently restored here

Code changes

  • AddEditPage.xaml: Removed Keyboard="Numeric" to allow the full keyboard to be used

Testing requirements

Create or modify a card and observe the keyboard type shown when the card number field is focused

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1617 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 10/28/2021 **Status:** ✅ Merged **Merged:** 10/28/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-ccnumalpha` --- ### 📝 Commits (1) - [`a687efb`](https://github.com/bitwarden/android/commit/a687efb089046f9a658a52c86a7e847a3efae81c) remove numeric restriction on cc number field ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/AddEditPage.xaml` (+0 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Remove numeric restriction on card number field that was originally removed [here](https://github.com/bitwarden/mobile/pull/1097) but inadvertently restored [here](https://github.com/bitwarden/mobile/pull/1365) ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AddEditPage.xaml:** Removed `Keyboard="Numeric"` to allow the full keyboard to be used ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> Create or modify a card and observe the keyboard type shown when the card number field is focused ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 22:49:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#22384