github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-17 10:04:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

Improve the search feature #222

New Issue
Closed
opened 2025-11-07 08:31:35 -06:00 by GiteaMirror · 8 comments
GiteaMirror commented 2025-11-07 08:31:35 -06:00
Owner
Copy Link

Originally created by @Hunsu on GitHub (May 12, 2018).

The search screen usually take 10s to show. Is it normal?
I think we should ignore spaces at the end of the search word. For example when I'm searching for Paypal password I usually type Pay and my keyboard suggest Paypal so when I accept that suggestion the keyboard add a space at the end and then the app show no results.

Originally created by @Hunsu on GitHub (May 12, 2018). The search screen usually take 10s to show. Is it normal? I think we should ignore spaces at the end of the search word. For example when I'm searching for Paypal password I usually type Pay and my keyboard suggest Paypal so when I accept that suggestion the keyboard add a space at the end and then the app show no results.
GiteaMirror commented 2025-11-07 08:31:35 -06:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (May 12, 2018):

No, that is not normal. Its nearly instant on my test device. What type of device are you using? How large is your vault?

@kspearrin commented on GitHub (May 12, 2018): No, that is not normal. Its nearly instant on my test device. What type of device are you using? How large is your vault?
GiteaMirror commented 2025-11-07 08:31:35 -06:00
Author
Owner
Copy Link

@Hunsu commented on GitHub (May 12, 2018):

I am using a Zuk Z2 Plus phone with an oreo custom rom. My vault is about a thousand entries.

@Hunsu commented on GitHub (May 12, 2018): I am using a Zuk Z2 Plus phone with an oreo custom rom. My vault is about a thousand entries.
GiteaMirror commented 2025-11-07 08:31:35 -06:00
Author
Owner
Copy Link

@keehun commented on GitHub (May 21, 2018):

I’m on an iPhone 6 and around 900 entries and search usually takes 4-5 seconds to load. It has gotten better in recent updates but still not as good as 1Password or even Enpass. Love Bitwarden in general, so I would love to keep supporting it!

@keehun commented on GitHub (May 21, 2018): I’m on an iPhone 6 and around 900 entries and search usually takes 4-5 seconds to load. It has gotten better in recent updates but still not as good as 1Password or even Enpass. Love Bitwarden in general, so I would love to keep supporting it!
GiteaMirror commented 2025-11-07 08:31:36 -06:00
Author
Owner
Copy Link

@trugty commented on GitHub (Jun 2, 2018):

I have a Samsung Galaxy S8 with around 900 sites. Clicking search regularly takes 10s or more for me.
I love the app otherwise but this really breaks up the workflow

@trugty commented on GitHub (Jun 2, 2018): I have a Samsung Galaxy S8 with around 900 sites. Clicking search regularly takes 10s or more for me. I love the app otherwise but this really breaks up the workflow
GiteaMirror commented 2025-11-07 08:31:36 -06:00
Author
Owner
Copy Link

@carlkibler commented on GitHub (Jun 25, 2018):

It is far worse on my phone, on the order of 1 minute before the Search screen is loaded and ready to use. I have 1662 items (yikes). I have a 2 year old, sort of low-end phone (BLU HD R1) but it is plenty fast for other heavy apps like Slack, Carcassonne, OneNote, etc.

I haven't looked at the code yet to see, but does it build a ListView with all items, rather than lazy-loading them? I can't imagine sorting the items is slow, so I assume it is a UI-rendering perf problem with all those items.

Also, why show password items at all on the search screen? Well, I understand some people might want to scroll through them. I would prefer not, if that's causing the huge delay.

My specific request would be, if the user has > 300 items (or 500, whatever), do not show the items list below the search box and instead show a button to "Show all items".

But also, I request looking at why the full items list is so slow when number of items is large. But please stop showing them all in the meantime! :)

@carlkibler commented on GitHub (Jun 25, 2018): It is far worse on my phone, on the order of 1 minute before the Search screen is loaded and ready to use. I have 1662 items (yikes). I have a 2 year old, sort of low-end phone (BLU HD R1) but it is plenty fast for other heavy apps like Slack, Carcassonne, OneNote, etc. I haven't looked at the code yet to see, but does it build a ListView with all items, rather than lazy-loading them? I can't imagine sorting the items is slow, so I assume it is a UI-rendering perf problem with all those items. Also, why show password items at all on the search screen? Well, I understand some people might want to scroll through them. I would prefer not, if that's causing the huge delay. My specific request would be, if the user has > 300 items (or 500, whatever), do not show the items list below the search box and instead show a button to "Show all items". But also, I request looking at why the full items list is so slow when number of items is large. But please stop showing them all in the meantime! :)
GiteaMirror commented 2025-11-07 08:31:36 -06:00
Author
Owner
Copy Link

@TheNicholasNick commented on GitHub (Mar 29, 2019):

super slow here as well - 2,145 items

search list should not load the list and then search.

it ought to search then show matches.

@TheNicholasNick commented on GitHub (Mar 29, 2019): super slow here as well - 2,145 items search list should not load the list and then search. it ought to search then show matches.
GiteaMirror commented 2025-11-07 08:31:37 -06:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Jun 4, 2019):

Can you test v2.0 beta on play store and see if this has been improved?

@kspearrin commented on GitHub (Jun 4, 2019): Can you test v2.0 beta on play store and see if this has been improved?
GiteaMirror commented 2025-11-07 08:31:37 -06:00
Author
Owner
Copy Link

@TheNicholasNick commented on GitHub (Jun 5, 2019):

Excellent, only have to wait ages for that first load. Doing a search is near instant now. Top job

@TheNicholasNick commented on GitHub (Jun 5, 2019): Excellent, only have to wait ages for that first load. Doing a search is near instant now. Top job
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#222
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?