github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 13:29:18 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

Empty word separator in passphrase generator still separates with space #2203

New Issue
Open
opened 2025-11-26 23:11:38 -06:00 by GiteaMirror · 9 comments
GiteaMirror commented 2025-11-26 23:11:38 -06:00
Owner
Copy Link

Originally created by @Arjun42 on GitHub (Mar 25, 2025).

Steps To Reproduce

  1. Go to 'Generator' bottom tab
  2. Click on 'Passphrase' top tab
  3. Select 'Word separator' field and remove all characters

Expected Result

Words in passphrase should not be separated by spaces or any other characters.

Actual Result

Words in passphrase are separated by a space.

Screenshots or Videos

https://github.com/user-attachments/assets/fe05874c-8ffd-4495-a4f3-6403c001d734

Additional Context

This works as expected on Bitwarden's Windows app, Firefox extension, and iOS app.

Build Version

2025.2.0 (19883)

What server are you connecting to?

US

Self-host Server Version

No response

Environment Details

Device: Samsung Galaxy Fold 4
OS: One UI 6.1.1 (Android 14)

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
Originally created by @Arjun42 on GitHub (Mar 25, 2025). ### Steps To Reproduce 1. Go to 'Generator' bottom tab 2. Click on 'Passphrase' top tab 3. Select 'Word separator' field and remove all characters ### Expected Result Words in passphrase should not be separated by spaces or any other characters. ### Actual Result Words in passphrase are separated by a space. ### Screenshots or Videos https://github.com/user-attachments/assets/fe05874c-8ffd-4495-a4f3-6403c001d734 ### Additional Context This works as expected on Bitwarden's Windows app, Firefox extension, and iOS app. ### Build Version 2025.2.0 (19883) ### What server are you connecting to? US ### Self-host Server Version _No response_ ### Environment Details Device: Samsung Galaxy Fold 4 OS: One UI 6.1.1 (Android 14) ### Issue Tracking Info - [x] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
GiteaMirror added the app:password-managerbug labels 2025-11-26 23:11:38 -06:00
GiteaMirror commented 2025-11-26 23:11:38 -06:00
Author
Owner
Copy Link

@S-Kakar commented on GitHub (Mar 25, 2025):

Thank you for your report! We've added this to our internal board for review.
ID: PM-19476

@S-Kakar commented on GitHub (Mar 25, 2025): Thank you for your report! We've added this to our internal board for review. ID: PM-19476
GiteaMirror commented 2025-11-26 23:11:38 -06:00
Author
Owner
Copy Link

@daniellbw commented on GitHub (Mar 25, 2025):

Hi there,

Your issue appears to be describing the intended behavior of the software. If you want this to be changed, it would be a feature request.

We use GitHub issues as a place to track bugs and other development related issues. The Bitwarden Community Forums has a Feature Requests section for submitting, voting for, and discussing requests like this one: https://community.bitwarden.com/c/feature-requests/

Please sign up on our forums (https://community.bitwarden.com/signup) and search to see if this request already exists. If so, you can vote for it and contribute to any discussions about it. If not, you can re-create the request there so that it can be properly tracked.

This issue will now be closed.

Thanks!

@daniellbw commented on GitHub (Mar 25, 2025): Hi there, Your issue appears to be describing the intended behavior of the software. If you want this to be changed, it would be a feature request. We use GitHub issues as a place to track bugs and other development related issues. The Bitwarden Community Forums has a Feature Requests section for submitting, voting for, and discussing requests like this one: https://community.bitwarden.com/c/feature-requests/ Please sign up on our forums (https://community.bitwarden.com/signup) and search to see if this request already exists. If so, you can vote for it and contribute to any discussions about it. If not, you can re-create the request there so that it can be properly tracked. This issue will now be closed. Thanks!
GiteaMirror commented 2025-11-26 23:11:39 -06:00
Author
Owner
Copy Link

@pamperer562580892423 commented on GitHub (Mar 25, 2025):

@daniellbw How is choosing "no letter or special character at all" between the passphrase words, but getting an unwanted space character inserted between the words the intended behaviour of the software?

To get something else as the setting I choose indicates, seems very clearly like a bug.

@pamperer562580892423 commented on GitHub (Mar 25, 2025): @daniellbw How is choosing "no letter or special character at all" between the passphrase words, but getting an unwanted space character inserted between the words the intended behaviour of the software? To get something else as the setting I choose indicates, seems very clearly like a bug.
GiteaMirror commented 2025-11-26 23:11:39 -06:00
Author
Owner
Copy Link

@Arjun42 commented on GitHub (Mar 25, 2025):

Thanks for the vote of confidence, @pamperer562580892423 .

@daniellbw I had already created a post on the Bitwarden Community forum and received feedback there that others are experiencing the same bug: https://community.bitwarden.com/t/empty-word-separator-in-passphrase-generator-still-separates-with-space/83071

Note that it works as expected on other platforms as noted in the above bug report. It's fine on the Windows app, Firefox extension, and iOS app. But it does not work as expected on the Android app.

I hope you can re-open the issue and provide another update.

Cheers!

@Arjun42 commented on GitHub (Mar 25, 2025): Thanks for the vote of confidence, @pamperer562580892423 . @daniellbw I had already created a post on the Bitwarden Community forum and received feedback there that others are experiencing the same bug: https://community.bitwarden.com/t/empty-word-separator-in-passphrase-generator-still-separates-with-space/83071 Note that it works as expected on other platforms as noted in the above bug report. It's fine on the Windows app, Firefox extension, and iOS app. But it does not work as expected on the Android app. I hope you can re-open the issue and provide another update. Cheers!
GiteaMirror commented 2025-11-26 23:11:39 -06:00
Author
Owner
Copy Link

@LougheadL commented on GitHub (Mar 25, 2025):

@daniellbw, how is this intended behaviour? The user is indicating that the separator should be a zero-length string, yet it is inserting a space. If intended, then why did you intend that?

@LougheadL commented on GitHub (Mar 25, 2025): @daniellbw, how is this intended behaviour? The user is indicating that the separator should be a zero-length string, yet it is inserting a space. If intended, then why did you intend that?
GiteaMirror commented 2025-11-26 23:11:39 -06:00
Author
Owner
Copy Link

@pamperer562580892423 commented on GitHub (Mar 25, 2025):

@daniellbw Having a different outcome only on the Android app, with the same settings as in the other apps (NO separator chosen), qualifies as a bug, I think - and can't be "intended". If it is intended, I would like to have an explanation, how this can be intended.

Here I would like to visualize the different outcomes in the different apps, as @Arjun42 already mentioned:

(for comparison, I chose the same settings now for every generator - 5 words, with Capizalization, Number included, and NO separator)

 

Chromium-based browser extension 2025.3.0 - no separator chosen, no separator used in the generated phrase:

Image

 

Web Vault 2025.3.0 - no separator chosen, no separator used in the generated phrase:

Image

 

Desktop App 2025.2.1 - no separator chosen, no separator used in the generated phrase:

Image

 

Android App 2025.2.0 - no separator chosen, BUT SPACE AS SEPARATOR used in the generated phrase:

Image

@pamperer562580892423 commented on GitHub (Mar 25, 2025): @daniellbw Having a different outcome only on the Android app, with the same settings as in the other apps (NO separator chosen), qualifies as a bug, I think - and can't be "intended". If it is intended, I would like to have an explanation, how this can be intended. Here I would like to visualize the different outcomes in the different apps, as @Arjun42 already mentioned: (for comparison, I chose the same settings now for every generator - 5 words, with Capizalization, Number included, and NO separator)   **Chromium-based browser extension 2025.3.0 - no separator chosen, no separator used in the generated phrase:** ![Image](https://github.com/user-attachments/assets/e8620a97-7cb4-453b-81d0-16508afa8fab)   **Web Vault 2025.3.0 - no separator chosen, no separator used in the generated phrase:** ![Image](https://github.com/user-attachments/assets/d5aa064b-99a4-4bf9-b808-350de595fabb)   **Desktop App 2025.2.1 - no separator chosen, no separator used in the generated phrase:** ![Image](https://github.com/user-attachments/assets/2b18eb61-4797-40b5-885b-a2e9a81c24d5)   **Android App 2025.2.0 - no separator chosen, BUT SPACE AS SEPARATOR used in the generated phrase:** ![Image](https://github.com/user-attachments/assets/a3717dcc-d0ca-45ae-abb0-1997215f0d31)
GiteaMirror commented 2025-11-26 23:11:39 -06:00
Author
Owner
Copy Link

@daniellbw commented on GitHub (Mar 26, 2025):

Hi @pamperer562580892423 and @Arjun42

Thank you for bringing this to our attention and all the information attached, I've notified our Engineering team of this inconsistent behaviour accross our clients and have reopened this github issue.

Again, thank you for all the relevant information provided!

@daniellbw commented on GitHub (Mar 26, 2025): Hi @pamperer562580892423 and @Arjun42 Thank you for bringing this to our attention and all the information attached, I've notified our Engineering team of this inconsistent behaviour accross our clients and have reopened this github issue. Again, thank you for all the relevant information provided!
GiteaMirror commented 2025-11-26 23:11:39 -06:00
Author
Owner
Copy Link

@m-klecka commented on GitHub (Sep 3, 2025):

@daniellbw its been 3 months since the pull request. Will the fix be merged?

@m-klecka commented on GitHub (Sep 3, 2025): @daniellbw its been 3 months since the pull request. Will the fix be merged?
GiteaMirror commented 2025-11-26 23:11:39 -06:00
Author
Owner
Copy Link

@cheintz commented on GitHub (Nov 22, 2025):

Any updates?

@cheintz commented on GitHub (Nov 22, 2025): Any updates?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label app:password-manager bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2203
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?