github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #825] [MERGED] Additional accessibility tweaks #21978

New Issue
Closed
opened 2026-04-16 22:33:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 22:33:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/825
Author: @mpbw2
Created: 4/9/2020
Status: ✅ Merged
Merged: 4/9/2020
Merged by: @mpbw2

Base: master ← Head: bugfixes-accessibility

📝 Commits (2)

📊 Changes

2 files changed (+34 additions, -32 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+22 -19)
📝 src/Android/Accessibility/AccessibilityService.cs (+12 -13)

📄 Description

  • Removed dependency on MainActivity for acquiring resource context from the GetSystemResourceDimenPx helper method as the "current" activity may not be ours (confirmed via invalid cast exceptions in crash logs). Now using the resource context from our own service.
  • Added some smarts to detect the presence of the autofill service prompt and back off if it's visible (we want the autofill service to take priority over accessibility - in most cases this happens automatically but in situations where it doesn't, this should help).
  • Moved time-based overload protection (as well as new autofill detection) in front of overlay permission warning toast. I believe the false positives (negatives?) returned by Settings.CanDrawOverlays(...) may be caused by excessive pounding on the method by accessibility events. This appears to have stopped the erroneous toasts in places I was able to reproduce it, but additional user feedback is needed as I can't reproduce it in all the places reported.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/825 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 4/9/2020 **Status:** ✅ Merged **Merged:** 4/9/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfixes-accessibility` --- ### 📝 Commits (2) - [`b1c3e23`](https://github.com/bitwarden/android/commit/b1c3e231035eba38e7070304d32c4d34b308c33d) Additional accessibility tweaks - [`3e08a38`](https://github.com/bitwarden/android/commit/3e08a387e603b65d97419bfdc2f5a697c69ed706) Cleanup ### 📊 Changes **2 files changed** (+34 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+22 -19) 📝 `src/Android/Accessibility/AccessibilityService.cs` (+12 -13) </details> ### 📄 Description - Removed dependency on MainActivity for acquiring resource context from the `GetSystemResourceDimenPx` helper method as the "current" activity may not be ours (confirmed via invalid cast exceptions in crash logs). Now using the resource context from our own service. - Added some smarts to detect the presence of the autofill service prompt and back off if it's visible (we want the autofill service to take priority over accessibility - in most cases this happens automatically but in situations where it doesn't, this should help). - Moved time-based overload protection (as well as new autofill detection) in front of overlay permission warning toast. I believe the false positives (negatives?) returned by `Settings.CanDrawOverlays(...)` may be caused by excessive pounding on the method by accessibility events. This appears to have stopped the erroneous toasts in places I was able to reproduce it, but additional user feedback is needed as I can't reproduce it in all the places reported. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 22:33:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#21978
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?