github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #777] [MERGED] Fix bug with policy banner visibility #21962

New Issue
Closed
opened 2026-04-16 22:32:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 22:32:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/777
Author: @vincentsalucci
Created: 3/16/2020
Status: ✅ Merged
Merged: 3/16/2020
Merged by: @vincentsalucci

Base: master ← Head: bug-policy-in-effect

📝 Commits (1)

  • da8b58a Fix bug with policy banner visibility

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Core/Models/Domain/PasswordGeneratorPolicyOptions.cs (+1 -1)

📄 Description

Objective

Policy In Effect banner is showing up for users not in an organization Reddit

Failure Point

  • Downstream code was expecting the PasswordGeneratorPolicyOptions object to have a default DefaultType of an empty string. This was not being set, causing the conditional DefaultType != "" to return true.

Code Changes

  • PasswordGeneratorPolicyOptions.cs: Added default value for DefaultType property. This now mimics the js codebase.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/777 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 3/16/2020 **Status:** ✅ Merged **Merged:** 3/16/2020 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `bug-policy-in-effect` --- ### 📝 Commits (1) - [`da8b58a`](https://github.com/bitwarden/android/commit/da8b58a7294e47fc0d47a32072caeee13dac564b) Fix bug with policy banner visibility ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Models/Domain/PasswordGeneratorPolicyOptions.cs` (+1 -1) </details> ### 📄 Description ## Objective > Policy In Effect banner is showing up for users not in an organization [Reddit](https://www.reddit.com/r/Bitwarden/comments/fjfies/one_or_more_organization_policies_are_affecting/) ## Failure Point - Downstream code was expecting the `PasswordGeneratorPolicyOptions` object to have a default `DefaultType` of an empty string. This was not being set, causing the conditional `DefaultType != ""` to return true. ## Code Changes - **PasswordGeneratorPolicyOptions.cs**: Added default value for `DefaultType` property. This now mimics the js codebase. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 22:32:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#21962
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?