github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

There should be two separate "Autofill" strings (verb/noun) #2196

New Issue
Open
opened 2025-11-26 23:11:28 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-26 23:11:28 -06:00
Owner
Copy Link

Originally created by @olavinto on GitHub (Mar 13, 2025).

There should be two separate "Autofill" strings in the mobile app, and probably on other's too. One that is a verb for strings that are about triggering the action, and another one as a noun for settings category headers etc. Currently there is only one such string so it must be used for both cases unless I'm missing something.

Not separating nouns and verbs because they are interchancable in English is not a good practice because they often aren't in many other languages (like Finnish in this case). This seems to be quite common issue with many localizations. This is propably one of the most common localization issues along with not providing separate plural forms and instead trying to use a smaller amount of # word(s) to get away with it (for Finnish, this sometimes works, but often not, and when it doesn't it is absolute hell to manage).

The line:
ca64ce2176/app/src/main/res/values-fi-rFI/strings.xml (L244)

At Crowdin this would be string #1438:
https://crowdin.com/editor/bitwarden-mobile/45/en-fi?view=comfortable&filter=basic&value=0#1438

Originally created by @olavinto on GitHub (Mar 13, 2025). There should be two separate "Autofill" strings in the mobile app, and probably on other's too. One that is a verb for strings that are about triggering the action, and another one as a noun for settings category headers etc. Currently there is only one such string so it must be used for both cases unless I'm missing something. Not separating nouns and verbs because they are interchancable in English is not a good practice because they often aren't in many other languages (like Finnish in this case). This seems to be quite common issue with many localizations. This is propably one of the most common localization issues along with not providing separate plural forms and instead trying to use a smaller amount of # word(s) to get away with it (for Finnish, this sometimes works, but often not, and when it doesn't it is absolute hell to manage). The line: https://github.com/bitwarden/android/blob/ca64ce2176cdb20f8afea74d6824cab92008dc8d/app/src/main/res/values-fi-rFI/strings.xml#L244 At Crowdin this would be string #1438: https://crowdin.com/editor/bitwarden-mobile/45/en-fi?view=comfortable&filter=basic&value=0#1438
GiteaMirror added the app:password-managerbug labels 2025-11-26 23:11:28 -06:00
GiteaMirror commented 2025-11-26 23:11:29 -06:00
Author
Owner
Copy Link

@S-Kakar commented on GitHub (Mar 13, 2025):

Thank you for your report! We've added this to our internal board for review.
ID: PM-19198

@S-Kakar commented on GitHub (Mar 13, 2025): Thank you for your report! We've added this to our internal board for review. ID: PM-19198
GiteaMirror commented 2025-11-26 23:11:29 -06:00
Author
Owner
Copy Link

@rmcdowell-bitwarden commented on GitHub (Mar 18, 2025):

Hi there,

Thank you for your report!

I have flagged this to our engineering team for their review.

@rmcdowell-bitwarden commented on GitHub (Mar 18, 2025): Hi there, Thank you for your report! I have flagged this to our engineering team for their review.
GiteaMirror commented 2025-11-26 23:11:29 -06:00
Author
Owner
Copy Link

@lucasmz-dev commented on GitHub (Oct 19, 2025):

Agree. This is problematic in Portuguese and the button (that you may get when an URI isn't saved) may be confused with a title

@lucasmz-dev commented on GitHub (Oct 19, 2025): Agree. This is problematic in Portuguese and the button (that you may get when an URI isn't saved) may be confused with a title
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label app:password-manager bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2196
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?