github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

Face unlock requires confirmation #2114

New Issue
Closed
opened 2025-11-26 23:08:30 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-26 23:08:30 -06:00
Owner
Copy Link

Originally created by @yaakovfeldman on GitHub (Jan 1, 2025).

Steps To Reproduce

When unlocking using Face as the biometric, the user must manually tap 'continue' each time after successfully authenticating. This is mildly annoying and does not match the behaviour when using Face ID on iOS or fingerprint on Android, which both unlock immediately after a successful scan without displaying such a modal.

The documentation https://developer.android.com/identity/sign-in/biometric-auth#no-explicit-user-action suggests this confirmation is intended for actions, such as making a purchase and can be skipped by adding .setConfirmationRequired(false) to a35ec8cf3c/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/biometrics/BiometricsManagerImpl.kt (L139)

I cannot add a screenshot due to the security policy but the documentation linked shows the modal and continue button. I note that users who really want to confirm every authentication can turn this on device wide in device settings.

Would you be open to a PR to add this?

There are plenty of comments on Reddit etc from people who find the current behaviour annoying, and it's not great having to do it every time I autofill! (The app is otherwise great - thanks!)

I am using a Pixel 9 with Android 15 and Bitwarden 2024.10.0

Expected Result

Vault unlocks immediately

Actual Result

Confirmation modal must be dismissed first

Screenshots or Videos

No response

Additional Context

No response

Build Version

2024.10.0

What server are you connecting to?

US

Self-host Server Version

No response

Environment Details

No response

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
Originally created by @yaakovfeldman on GitHub (Jan 1, 2025). ### Steps To Reproduce When unlocking using Face as the biometric, the user must manually tap 'continue' each time after successfully authenticating. This is mildly annoying and does not match the behaviour when using Face ID on iOS or fingerprint on Android, which both unlock immediately after a successful scan without displaying such a modal. The documentation https://developer.android.com/identity/sign-in/biometric-auth#no-explicit-user-action suggests this confirmation is intended for actions, such as making a purchase and can be skipped by adding `.setConfirmationRequired(false)` to https://github.com/bitwarden/android/blob/a35ec8cf3c19ecc83791c9b89825ff6008e47a2c/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/biometrics/BiometricsManagerImpl.kt#L139 I cannot add a screenshot due to the security policy but the documentation linked shows the modal and continue button. I note that users who really want to confirm every authentication can turn this on device wide in device settings. Would you be open to a PR to add this? There are plenty of comments on Reddit etc from people who find the current behaviour annoying, and it's not great having to do it every time I autofill! (The app is otherwise great - thanks!) I am using a Pixel 9 with Android 15 and Bitwarden 2024.10.0 ### Expected Result Vault unlocks immediately ### Actual Result Confirmation modal must be dismissed first ### Screenshots or Videos _No response_ ### Additional Context _No response_ ### Build Version 2024.10.0 ### What server are you connecting to? US ### Self-host Server Version _No response_ ### Environment Details _No response_ ### Issue Tracking Info - [X] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
GiteaMirror added the bug label 2025-11-26 23:08:30 -06:00
GiteaMirror commented 2025-11-26 23:08:30 -06:00
Author
Owner
Copy Link

@bitwarden-bot commented on GitHub (Jan 1, 2025):

Thank you for your report! We've added this to our internal board for review.
ID: PM-16599

@bitwarden-bot commented on GitHub (Jan 1, 2025): Thank you for your report! We've added this to our internal board for review. ID: PM-16599
GiteaMirror commented 2025-11-26 23:08:30 -06:00
Author
Owner
Copy Link

@SaintPatrck commented on GitHub (Jan 9, 2025):

Hi @yaakovfeldman

I'm happy to inform you this has already been resolved in the latest native version of the application that is actively rolling out. If you prefer to not wait for rollout through Play Store, you can download the latest version from our F-Droid repository.

@SaintPatrck commented on GitHub (Jan 9, 2025): Hi @yaakovfeldman I'm happy to inform you this has already been resolved in the latest native version of the application that is actively rolling out. If you prefer to not wait for rollout through Play Store, you can download the latest version from our [F-Droid repository](https://github.com/bitwarden/f-droid).
GiteaMirror commented 2025-11-26 23:08:31 -06:00
Author
Owner
Copy Link

@yaakovfeldman commented on GitHub (Feb 23, 2025):

@SaintPatrck thanks but I think there is some confusion here as the specific issue I mentioned hasn't been added? I still need to manually tap Continue after every successful face authentication.

@yaakovfeldman commented on GitHub (Feb 23, 2025): @SaintPatrck thanks but I think there is some confusion here as the specific issue I mentioned hasn't been added? I still need to manually tap Continue after every successful face authentication.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2114
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?