github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

matchUri is getting an error #2062

New Issue
Open
opened 2025-11-26 23:06:44 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-26 23:06:44 -06:00
Owner
Copy Link

Originally created by @Seed680 on GitHub (Nov 12, 2024).

Steps To Reproduce

In the AutofillParserImpl.kt class within the com.x8bit.bitwarden.data.autofill.parser package, the parseInternal method, specifically the line 97

val uri = traversalDataList.buildUriOrNull( packageName = packageName, )

does not correctly retrieve the URI. If the URI is "http://102.168.5.6:5700", the result for uri is "http://102.168.5.6", and the port number is not correctly obtained.
image

Expected Result

If the URI is "http://192.168.5.6:5700", the result for uri is "http://192.168.5.6:5700",

Actual Result

If the URI is "http://192.168.5.6:5700", the result for uri is "http://192.168.5.6", no port info

Screenshots or Videos

No response

Additional Context

No response

Build Version

2024.11.3(19432)

What server are you connecting to?

US

Self-host Server Version

No response

Environment Details

No response

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
Originally created by @Seed680 on GitHub (Nov 12, 2024). ### Steps To Reproduce In the `AutofillParserImpl.kt` class within the `com.x8bit.bitwarden.data.autofill.parser` package, the `parseInternal` method, specifically the line 97 ```val uri = traversalDataList.buildUriOrNull( packageName = packageName, ) ``` does not correctly retrieve the URI. If the URI is `"http://102.168.5.6:5700"`, the result for `uri` is `"http://102.168.5.6"`, and the port number is not correctly obtained. ![image](https://github.com/user-attachments/assets/015908cd-a37c-414f-8014-e1ab33cb22dd) ### Expected Result If the URI is `"http://192.168.5.6:5700"`, the result for `uri` is `"http://192.168.5.6:5700"`, ### Actual Result If the URI is `"http://192.168.5.6:5700"`, the result for `uri` is `"http://192.168.5.6"`, no port info ### Screenshots or Videos _No response_ ### Additional Context _No response_ ### Build Version 2024.11.3(19432) ### What server are you connecting to? US ### Self-host Server Version _No response_ ### Environment Details _No response_ ### Issue Tracking Info - [X] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
GiteaMirror added the app:password-managerbug labels 2025-11-26 23:06:44 -06:00
GiteaMirror commented 2025-11-26 23:06:45 -06:00
Author
Owner
Copy Link

@bitwarden-bot commented on GitHub (Nov 12, 2024):

Thank you for your report! We've added this to our internal board for review.
ID: PM-14846

@bitwarden-bot commented on GitHub (Nov 12, 2024): Thank you for your report! We've added this to our internal board for review. ID: PM-14846
GiteaMirror commented 2025-11-26 23:06:45 -06:00
Author
Owner
Copy Link

@SaintPatrck commented on GitHub (May 1, 2025):

@david-livefront this is what we were discussing earlier.

@SaintPatrck commented on GitHub (May 1, 2025): @david-livefront this is what we were discussing earlier.
GiteaMirror commented 2025-11-26 23:06:45 -06:00
Author
Owner
Copy Link

@Seed680 commented on GitHub (May 1, 2025):

@david-livefront this is what we were discussing earlier.

Is this an unintended error？

@Seed680 commented on GitHub (May 1, 2025): > [@david-livefront](https://github.com/david-livefront) this is what we were discussing earlier. Is this an unintended error？
GiteaMirror commented 2025-11-26 23:06:45 -06:00
Author
Owner
Copy Link

@SaintPatrck commented on GitHub (May 1, 2025):

Hi @Seed680,

This is caused by a limitation in the Autofill framework. Until Google provides more than the domain and scheme we are not able to perform any matching or field population with port, path, or query string information.

As an alternative, you can use the Autofill quick tile when Accessibility is enabled, which does capture the full URL. If you do go this route, be aware we recently identified an issue matching IP addresses with ports but no scheme, ie 10.0.2.2:1234. We are tracking that issue and hope to have a fix soon.

You can refer to https://github.com/bitwarden/mobile/issues/2124#issuecomment-2839759140 for more details on the Autofill limitations.

@SaintPatrck commented on GitHub (May 1, 2025): Hi @Seed680, This is caused by a limitation in the Autofill framework. Until Google provides more than the domain and scheme we are not able to perform any matching or field population with port, path, or query string information. As an alternative, you can use the Autofill quick tile when Accessibility is enabled, which does capture the full URL. If you do go this route, be aware we recently identified an issue matching IP addresses with ports but no scheme, ie `10.0.2.2:1234`. We are tracking that issue and hope to have a fix soon. You can refer to https://github.com/bitwarden/mobile/issues/2124#issuecomment-2839759140 for more details on the Autofill limitations.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label app:password-manager bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2062
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?