github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6779] [BWA-99] feat: Add next TOTP code preview in Authenticator #19615

New Issue
Open
opened 2026-04-15 03:55:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 03:55:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6779
Author: @SaintPatrck
Created: 4/9/2026
Status: 🔄 Open

Base: main ← Head: bwa-99/next-totp-code-preview

📝 Commits (5)

  • ab0d367 [BWA-99] feat: Add next TOTP code preview in Authenticator
  • eb9cd20 Add test coverage for show next code setting
  • a32c994 Address code review feedback
  • f7f816f Add tests for nextAuthCode threshold and toggle filtering
  • ac66724 Update strings

📊 Changes

26 files changed (+561 additions, -25 deletions)

View changed files

📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/manager/TotpCodeManagerImpl.kt (+8 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/manager/model/VerificationCodeItem.kt (+2 -1)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/SettingsDiskSource.kt (+10 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/SettingsDiskSourceImpl.kt (+15 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/SettingsRepository.kt (+10 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/SettingsRepositoryImpl.kt (+16 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingViewModel.kt (+32 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/search/ItemSearchViewModel.kt (+33 -1)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/util/SharedVerificationCodesStateExtensions.kt (+2 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/util/VerificationCodeItemExtensions.kt (+6 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/VaultVerificationCodeItem.kt (+48 -9)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/VerificationCodeDisplayItem.kt (+1 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt (+20 -11)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsViewModel.kt (+41 -0)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/data/authenticator/manager/util/TotpCodeManagerTest.kt (+41 -0)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/data/authenticator/manager/util/VerificationCodeItemUtil.kt (+2 -0)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/SettingDiskSourceTest.kt (+27 -0)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/data/platform/repository/SettingsRepositoryTest.kt (+35 -0)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreenTest.kt (+1 -0)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingViewModelTest.kt (+12 -1)

...and 6 more files

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BWA-99

📔 Objective

Add a "next TOTP code" preview to the Authenticator app. When a verification code is about to expire (< 10 seconds remaining), the upcoming code is displayed below the current one, allowing users to pre-read the next code without waiting for rotation.

Key behaviors:

  • Next code appears only when timeLeftSeconds < 10
  • Displayed in smaller, secondary-color text below the current code
  • Controlled by a "Show next code" toggle in Settings > Data (default: off)
  • Tapping an item still copies the current code

Implementation details:

  • Data layer: Second generateTotp() SDK call with currentTime + periodSeconds
  • Settings: Full DiskSource → Repository → ViewModel → Screen chain for the toggle
  • UI: Conditional rendering in VaultVerificationCodeItem composable
  • Wired through both ItemListingViewModel and ItemSearchViewModel

📸 Screenshots

Settings

Figma Actual

Disclaimer: Figma includes the new Switch row, but other settings are outdated.

Upcoming code

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6779 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/9/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `bwa-99/next-totp-code-preview` --- ### 📝 Commits (5) - [`ab0d367`](https://github.com/bitwarden/android/commit/ab0d367299ed371714b4761c89ab16fd4d498553) [BWA-99] feat: Add next TOTP code preview in Authenticator - [`eb9cd20`](https://github.com/bitwarden/android/commit/eb9cd20095b13a20e22258e9f596b9d4d8d4ea66) Add test coverage for show next code setting - [`a32c994`](https://github.com/bitwarden/android/commit/a32c99486c12e0e3aa9571a1f56e721c863c7134) Address code review feedback - [`f7f816f`](https://github.com/bitwarden/android/commit/f7f816f35718723e71867ea303e5a8530998e445) Add tests for nextAuthCode threshold and toggle filtering - [`ac66724`](https://github.com/bitwarden/android/commit/ac66724d1e7aa3e1815bfece619eb37e3cd03e0d) Update strings ### 📊 Changes **26 files changed** (+561 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/manager/TotpCodeManagerImpl.kt` (+8 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/manager/model/VerificationCodeItem.kt` (+2 -1) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/SettingsDiskSource.kt` (+10 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/SettingsDiskSourceImpl.kt` (+15 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/SettingsRepository.kt` (+10 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/SettingsRepositoryImpl.kt` (+16 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingViewModel.kt` (+32 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/search/ItemSearchViewModel.kt` (+33 -1) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/util/SharedVerificationCodesStateExtensions.kt` (+2 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/util/VerificationCodeItemExtensions.kt` (+6 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/VaultVerificationCodeItem.kt` (+48 -9) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/components/listitem/model/VerificationCodeDisplayItem.kt` (+1 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt` (+20 -11) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsViewModel.kt` (+41 -0) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/data/authenticator/manager/util/TotpCodeManagerTest.kt` (+41 -0) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/data/authenticator/manager/util/VerificationCodeItemUtil.kt` (+2 -0) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/data/platform/datasource/disk/SettingDiskSourceTest.kt` (+27 -0) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/data/platform/repository/SettingsRepositoryTest.kt` (+35 -0) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreenTest.kt` (+1 -0) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingViewModelTest.kt` (+12 -1) _...and 6 more files_ </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/BWA-99 ## 📔 Objective Add a "next TOTP code" preview to the Authenticator app. When a verification code is about to expire (< 10 seconds remaining), the upcoming code is displayed below the current one, allowing users to pre-read the next code without waiting for rotation. **Key behaviors:** - Next code appears only when `timeLeftSeconds < 10` - Displayed in smaller, secondary-color text below the current code - Controlled by a "Show next code" toggle in Settings > Data (default: off) - Tapping an item still copies the **current** code **Implementation details:** - Data layer: Second `generateTotp()` SDK call with `currentTime + periodSeconds` - Settings: Full `DiskSource → Repository → ViewModel → Screen` chain for the toggle - UI: Conditional rendering in `VaultVerificationCodeItem` composable - Wired through both `ItemListingViewModel` and `ItemSearchViewModel` ## 📸 Screenshots ### Settings | Figma | Actual | |--------|--------| | <img width="365" src="https://github.com/user-attachments/assets/67d2f873-937b-422c-a4ca-6bf6a088aa3a" /> | <img width="365" src="https://github.com/user-attachments/assets/51a860f5-46cd-415a-bccc-70b9b22050b5" /> | *Disclaimer: Figma includes the new Switch row, but other settings are outdated.* ### Upcoming code <video src="https://github.com/user-attachments/assets/b8337cce-0b52-4c17-9ffb-623f7a460397" width="365" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 03:55:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#19615
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?